fix(wework): correct cloud work refresh status - #2516
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughCloud Work status now reflects complete background probes. Initial checks show ChangesCloud Work Status
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant WorkbenchProvider
participant refreshCloudBackgroundData
participant workbenchCloudStatus
participant CloudServices
WorkbenchProvider->>refreshCloudBackgroundData: request cloud refresh
refreshCloudBackgroundData->>refreshCloudBackgroundData: abandon and abort previous refresh
refreshCloudBackgroundData->>workbenchCloudStatus: mark checks as syncing
refreshCloudBackgroundData->>CloudServices: probe teams, devices, and runtime work
CloudServices-->>refreshCloudBackgroundData: return probe results
refreshCloudBackgroundData->>workbenchCloudStatus: publish completed or unavailable status
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Syncingonly during the first complete cloud probeAvailable,No devices, orUnavailableresult visible during later refreshesRoot cause
The sidebar status reused
lastGood, which is a data cache, as the current availability result. A failed or superseded refresh could therefore fall back to a historical successful status. Overlapping refreshes also had a device-only path that did not publish failures back into the cloud status state.Impact
Cloud Work now becomes unavailable when Backend reads fail, while cached devices and runtime work may still remain visible. Later refreshes no longer flash through
Syncing; they transition directly between the last completed result and the new completed result.Validation
git diff --checkSummary by CodeRabbit
Bug Fixes
Documentation