Skip to content

fix(wework): use consistent opaque window surfaces - #2493

Merged
qdaxb merged 3 commits into
mainfrom
fix/opaque-window-background
Aug 7, 2026
Merged

fix(wework): use consistent opaque window surfaces#2493
qdaxb merged 3 commits into
mainfrom
fix/opaque-window-background

Conversation

@qdaxb

@qdaxb qdaxb commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • disable native transparency and sidebar window effects for the main Wework window and detached workspace windows
  • use the application surface color for the titlebar and exposed window frame in both light and dark themes
  • remove the obsolete desktop vibrancy and titlebar blur paths
  • document the opaque-window contract in the Chinese and English macOS developer guides

Root cause

The macOS windows enabled Tauri transparency and the native sidebar material while the WebView root was also transparent. macOS versions and graphics environments compose those edges differently, so the frame could expose the desktop, appear translucent, or render gray. Simply disabling native transparency exposed a separate blue-gray titlebar token, so the final fix also aligns the frame and titlebar with the normal application surface.

Impact

The main window and detached workspace windows now render an opaque, consistent neutral frame across supported systems. The system drag panel and Popout Window remain intentionally transparent lightweight overlays.

Validation

  • Prettier checks passed
  • ESLint passed
  • TypeScript passed
  • Wework unit tests passed in pre-push
  • focused window regression suite: 41 tests passed
  • isolated real Tauri application built and launched successfully

Task: WEWORKC2FA61-65

Summary by CodeRabbit

  • Bug Fixes

    • Standardized workspace windows with opaque surfaces for improved visual consistency.
    • Removed transparency, blur, saturation, and native window effects from standard desktop windows.
    • Updated light and dark titlebars to match their corresponding surface colors.
  • Documentation

    • Added guidance on window surface requirements and verification for main and detached workspace windows.
  • Tests

    • Added coverage to prevent accidental reintroduction of transparent or native window effects.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a48ac7a3-3856-4e92-b42f-76bb7d72b9d6

📥 Commits

Reviewing files that changed from the base of the PR and between 1edb23c and 19ebdfa.

📒 Files selected for processing (11)
  • docs/en/wework/developer-guide/wework-macos-release.md
  • docs/zh/wework/developer-guide/wework-macos-release.md
  • wework/src-tauri/tauri.conf.json
  • wework/src/App.tsx
  • wework/src/components/topnav/ChromeTitlebar.test.tsx
  • wework/src/components/topnav/ChromeTitlebar.tsx
  • wework/src/features/workspace-tabs/workspaceWindow.test.ts
  • wework/src/features/workspace-tabs/workspaceWindow.ts
  • wework/src/styles/globals.css
  • wework/src/test/macos-window-chrome.test.ts
  • wework/src/test/theme-token-guard.test.ts

📝 Walkthrough

Walkthrough

Wework now uses opaque Tauri windows without native effects or vibrancy. Surface colors cover the WebView and titlebar. Tests enforce the configuration and theme rules, and bilingual documentation describes the window constraints.

Changes

Opaque window surfaces

Layer / File(s) Summary
Window configuration
wework/src-tauri/tauri.conf.json, wework/src/features/workspace-tabs/workspaceWindow.ts
Main and workspace windows now disable transparency and native window effects.
Surface rendering
wework/src/App.tsx, wework/src/components/topnav/ChromeTitlebar.tsx, wework/src/styles/globals.css
Removed vibrancy fallbacks and backdrop effects. Updated light and dark titlebar colors to match surface colors.
Validation and documentation
wework/src/.../*.test.ts, docs/en/wework/developer-guide/wework-macos-release.md, docs/zh/wework/developer-guide/wework-macos-release.md
Tests enforce opaque windows, absent effects, titlebar styling, and unique theme tokens. Release guides document the same constraints.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: micro66

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: making Wework window surfaces consistent and opaque.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 2
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/opaque-window-background

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qdaxb
qdaxb marked this pull request as ready for review August 7, 2026 10:24
@qdaxb
qdaxb enabled auto-merge August 7, 2026 10:24
@qdaxb
qdaxb added this pull request to the merge queue Aug 7, 2026
Merged via the queue into main with commit 8ca9843 Aug 7, 2026
71 of 74 checks passed
@qdaxb
qdaxb deleted the fix/opaque-window-background branch August 7, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant