fix(wework): use consistent opaque window surfaces - #2493
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
📝 WalkthroughWalkthroughWework now uses opaque Tauri windows without native effects or vibrancy. Surface colors cover the WebView and titlebar. Tests enforce the configuration and theme rules, and bilingual documentation describes the window constraints. ChangesOpaque window surfaces
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
qdaxb
marked this pull request as ready for review
August 7, 2026 10:24
qdaxb
enabled auto-merge
August 7, 2026 10:24
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The macOS windows enabled Tauri transparency and the native sidebar material while the WebView root was also transparent. macOS versions and graphics environments compose those edges differently, so the frame could expose the desktop, appear translucent, or render gray. Simply disabling native transparency exposed a separate blue-gray titlebar token, so the final fix also aligns the frame and titlebar with the normal application surface.
Impact
The main window and detached workspace windows now render an opaque, consistent neutral frame across supported systems. The system drag panel and Popout Window remain intentionally transparent lightweight overlays.
Validation
Task: WEWORKC2FA61-65
Summary by CodeRabbit
Bug Fixes
Documentation
Tests