-
Notifications
You must be signed in to change notification settings - Fork 125
feat(wework): generate friendly task titles #2471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3d48485
feat(wework): generate friendly task titles
qdaxb 7bbd80f
refactor(wework): move friendly title setting
qdaxb b1fc258
style(wework): compact title model setting
qdaxb 4eed722
fix(wework): hide title model when disabled
qdaxb 9692019
Merge branch 'main' into feature/wework-friendly-task-titles
qdaxb 6646bbc
Merge branch 'main' into feature/wework-friendly-task-titles
qdaxb 2e60333
test(wework): remove obsolete GPT 5.5 assertion
qdaxb 33da32a
fix(wework): keep standalone tasks out of project sidebar
qdaxb 9196e19
test(wework): use canonical GPT 5.5 model option
qdaxb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🔴 Critical | 🏗️ Heavy lift
Replace the whole-link upsert with an in-place
update_taskmutation.latest_linkis read at Line 99 (or Line 83) and written back in full at Line 132. Friendly-title generation runs concurrently with the main turn spawned bycreate_task, and that turn mutates the same stored link throughmark_task_running_for_sendandrecord_runtime_turn_id. Any field those paths write between the read andupsert_local_taskis reverted by this stale snapshot, includingthread_id,runtime_handleturn mappings,updated_at, andcompleted_at. The title check at Line 101 is also a time-of-check/time-of-use gap: a rename that lands after the check is overwritten.Mutate only the title through
self.store.update_task, and re-verify the source title inside the closure so the guard and the write are atomic.🐛 Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents