Migrate to pyproject.toml, fix cChardet build issue - #38
Open
Shrinks99 wants to merge 20 commits into
Open
Conversation
Some aspects of UV aren't supported by pylock.toml and UV treats it as an export format. If we're gonna use it, best to go all the way!
Gone but not forgotten
- Align bullet character usage in file
Shrinks99
marked this pull request as ready for review
August 8, 2026 01:44
Collaborator
Author
|
@ikreymer This should be ready to go :) |
passed all the tests, why not keep it up to date?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27
While migrating my own Python install fully to UV tonight, I was unable to get warcit installed due to the issue documented in #27. Figured I'd have a go at fixing it while taking the time to understand authoring a pyproject file. UV isn't required to build warcit with these changes, but it sure is helpful for managing python versions & environments!
This also means that developers will be able to install warcit in editable mode!
Tested with
uv run warcit -V,uv build, anduv tool install -e .Changes
setup.pyto a modernpyproject.tomlfilefaust-cchardetforkrequires-pythonvalue of>=3.10test_warcit.py(required as of V6)utf-8was previously incorrectly detected aswindows-1258now that faust-cchardet is used.Todo