Skip to content

aamtests (EdgeDriver): Compute correct pid & Enable running IA2 tests #60733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spectranaut merged 6 commits into from
Jun 30, 2026
Merged

aamtests (EdgeDriver): Compute correct pid & Enable running IA2 tests #60733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23b5abe
Compute pid properly for `EdgeDriver` in fixtures_a11y_api.py
yezhizhen Jun 18, 2026
06f44c9
Find browser window handle by pid in `ia2_wrapper.py`
yezhizhen Jun 18, 2026
b816a0d
Merge branch 'master' into patch-1
yezhizhen Jun 24, 2026
4263c76
pass pid
yezhizhen Jun 24, 2026
22c48f0
Add back fallback with browser name
yezhizhen Jun 24, 2026
0f8ac91
Use product name `edge`
yezhizhen Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core-aam/aamtests/support/fixtures_a11y_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ def pid_from(capabilities):
return capabilities["moz:processID"], "firefox"
if "safari:processID" in capabilities:
return capabilities["safari:processID"], capabilities["browserName"]
if capabilities["browserName"] == "MicrosoftEdge":
return capabilities["goog:processID"], "edge"
return 0, capabilities["browserName"]


Expand Down
23 changes: 19 additions & 4 deletions core-aam/aamtests/support/ia2_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import ctypes
from ctypes import POINTER, byref
from ctypes.wintypes import BOOL, HWND, LPARAM
from ctypes.wintypes import BOOL, DWORD, HWND, LPARAM

# Type aliases for COM interface pointers.
# These are dynamically generated by comtypes at runtime.
Expand Down Expand Up @@ -48,9 +48,20 @@ def name_from_hwnd(hwnd: HWND) -> str:
return buffer.value


def get_browser_hwnd(product_name: str) -> HWND:
def get_browser_hwnd(product_name: str, pid: int) -> HWND:
found: List[HWND] = []

@ctypes.WINFUNCTYPE(BOOL, HWND, LPARAM) # type: ignore[attr-defined, misc]
def check_pid(hwnd: HWND, lParam: LPARAM) -> bool: # noqa: N803
window_pid = DWORD()
user32.GetWindowThreadProcessId(hwnd, ctypes.byref(window_pid))
if window_pid.value != pid:
# EnumWindows should continue enumerating
return True
found.append(hwnd)
# EnumWindows should stop enumerating (since we found the right window)
return False

@ctypes.WINFUNCTYPE(BOOL, HWND, LPARAM) # type: ignore[attr-defined, misc]
def check_window_name(hwnd: HWND, lParam: LPARAM) -> bool: # noqa: N803
window_name = name_from_hwnd(hwnd)
Expand All @@ -61,7 +72,11 @@ def check_window_name(hwnd: HWND, lParam: LPARAM) -> bool: # noqa: N803
# EnumWindows should stop enumerating (since we found the right window)
return False

user32.EnumWindows(check_window_name, LPARAM(0))
if pid:
user32.EnumWindows(check_pid, LPARAM(0))
else:
user32.EnumWindows(check_window_name, LPARAM(0))

if not found:
raise LookupError(f"Couldn't find {product_name} HWND")
return found[0]
Expand Down Expand Up @@ -118,7 +133,7 @@ def _find_browser(self) -> Optional[IAccessible2Ptr]:

:return: IAccessible2Ptr.
"""
hwnd = get_browser_hwnd(self.product_name)
hwnd = get_browser_hwnd(self.product_name, self.pid)
root = accessible_object_from_window(hwnd)
return to_ia2(root)

Expand Down
Loading