-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Adding Retention for Application #338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+155
−18
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package reconciler | ||
|
|
||
| import ( | ||
| "context" | ||
| "testing" | ||
| "time" | ||
|
|
||
| apiv2 "github.com/wandb/operator/api/v2" | ||
| serverManifest "github.com/wandb/operator/pkg/wandb/manifest" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "sigs.k8s.io/controller-runtime/pkg/client/fake" | ||
| ) | ||
|
|
||
| func TestResolveEnvvarsCustomResourceRetention(t *testing.T) { | ||
| retentionPeriod := metav1.Duration{Duration: 168 * time.Hour} | ||
| wandb := &apiv2.WeightsAndBiases{ | ||
| ObjectMeta: metav1.ObjectMeta{Name: "wandb", Namespace: "default"}, | ||
| } | ||
| wandb.Spec.Wandb.Retention = &apiv2.RetentionSpec{ | ||
| ArtifactGarbageCollection: true, | ||
| DataRetentionPeriod: &retentionPeriod, | ||
| } | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| field string | ||
| expected string | ||
| }{ | ||
| { | ||
| name: "GORILLA_ARTIFACT_GC_ENABLED", | ||
| field: "spec.wandb.retention.artifactGarbageCollection", | ||
| expected: "true", | ||
| }, | ||
| { | ||
| name: "GORILLA_DATA_RETENTION_PERIOD", | ||
| field: "spec.wandb.retention.dataRetentionPeriod", | ||
| expected: "168h0m0s", | ||
| }, | ||
| } | ||
|
|
||
| envs := make([]serverManifest.EnvVar, 0, len(tests)) | ||
| for _, tc := range tests { | ||
| envs = append(envs, serverManifest.EnvVar{ | ||
| Name: tc.name, | ||
| Sources: []serverManifest.EnvSource{{ | ||
| Type: "custom-resource", Field: tc.field, | ||
| }}, | ||
| }) | ||
| } | ||
|
|
||
| resolved, err := resolveEnvvars( | ||
| context.Background(), | ||
| fake.NewClientBuilder().Build(), | ||
| wandb, | ||
| serverManifest.Manifest{}, | ||
| nil, | ||
| envs, | ||
| ) | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
|
|
||
| for _, tc := range tests { | ||
| env := mustFindEnvVar(t, resolved, tc.name) | ||
| if env.Value != tc.expected { | ||
| t.Errorf("expected %s=%q, got %q", tc.name, tc.expected, env.Value) | ||
| } | ||
| if env.ValueFrom != nil { | ||
| t.Errorf("expected %s to be a plain value, got valueFrom %+v", tc.name, env.ValueFrom) | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the trailing blank line.
YAMLlint reports
too many blank lines (1 > 0)at line 40. Remove the extra blank line somake lintpasses.🧹 Proposed fix
clickhouse: managedClickhouse: telemetry: enabled: true -🧰 Tools
🪛 YAMLlint (1.37.1)
[error] 40-40: too many blank lines (1 > 0)
(empty-lines)
🤖 Prompt for AI Agents
Source: Linters/SAST tools