-
Notifications
You must be signed in to change notification settings - Fork 157
Update a no href to map to link role #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 5 commits
9c323bc
decf99a
d523b9b
010bba9
5e7a033
184cbb5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -220,3 +220,6 @@ pip-log.txt | |
|
|
||
| # Local Netlify folder | ||
| .netlify | ||
|
|
||
| # Jet Brains | ||
| .idea/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -405,6 +405,56 @@ <h4 id="el-a-no-href">`a` <span class="el-context">(no `href` attribute)</span>< | |
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <h4 id="el-a-click-listener">`a` <span class="el-context">(with click listener)</span></h4> | ||
| <table class="data" aria-labelledby="el-a-click-listener"> | ||
| <tbody> | ||
| <tr> | ||
| <th>HTML Specification</th> | ||
| <td> | ||
| <a data-cite="HTML">`a`</a> | ||
| <span class="el-context">(with click listener)</span> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <th>[[wai-aria-1.2]]</th> | ||
| <td><a class="core-mapping" href="#role-map-link">`link`</a> role</td> | ||
| </tr> | ||
| <tr> | ||
| <th><a data-cite="core-aam-1.2/#roleMappingComputedRole">Computed Role</a></th> | ||
| <td class="role-computed"><div class="general">Use WAI-ARIA mapping</div></td> | ||
| </tr> | ||
| <tr> | ||
| <th> | ||
| <a href="https://msdn.microsoft.com/en-us/library/dd373608%28v=VS.85%29.aspx">MSAA</a> + <a href="http://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/">IAccessible2</a> | ||
| </th> | ||
| <td> | ||
| <div class="general">Use WAI-ARIA mapping</div> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <th><a href="https://msdn.microsoft.com/en-us/library/ms726297%28v=VS.85%29.aspx">UIA</a></th> | ||
| <td> | ||
| <div class="general">Use WAI-ARIA mapping</div> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <th><span class="informative">[[ATK]]</span></th> | ||
| <td> | ||
| <div class="general">Use WAI-ARIA mapping</div> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <th><a href="https://developer.apple.com/reference/appkit/nsaccessibility">AX</a></th> | ||
| <td> | ||
| <div class="general">Use WAI-ARIA mapping</div> | ||
| </td> | ||
| </tr> | ||
| <tr> | ||
| <th>Comments</th> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Might be good to specify that this applies only to direct onClick and click event listeners in the comments for clarity. Especially as delegated event listeners become more common and James' callout. |
||
| <td></td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <h4 id="el-abbr">`abbr`</h4> | ||
| <table class="data" aria-labelledby="el-abbr"> | ||
| <tbody> | ||
|
|
@@ -17060,6 +17110,7 @@ <h3>Change Log</h3> | |
| <section> | ||
| <h4>Substantive changes since moving to the <a href="https://www.w3.org/WAI/ARIA/">Accessible Rich Internet Applications Working Group</a> (03-Nov-2019)</h4> | ||
| <ul> | ||
| <li>12-Aug-2026: Add `a with click listener` to have `link` role in keeping with browser implementations. See <a href="https://github.com/w3c/html-aam/issues/608">GitHub Issue 608</a> </li> | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: missing period/. before |
||
| <li>2-April-2025: Add `command` and `commandfor` attribute mappings. See <a href="https://github.com/w3c/aria/pull/2354/">GitHub ARIA PR 2354</a>.</li> | ||
| <li>11-July-2024: User Agents ignore `aria-hidden=true` on `body` and `html` elements. See <a href="https://github.com/w3c/html-aam/pull/516">GitHub PR 516</a>.</li> | ||
| <li>06-June-2024: Add concept of Minimum Role. See <a href="https://github.com/w3c/html-aam/pull/454">GitHub PR 454</a>.</li> | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Calling it out as this seems auxiliary like something JetBrains added. Might be good to separate if we feel like this is a helpful addition to '.gitignore', but that might be personal preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually added this following the existing pattern. You think this should be taken out and put in a different PR?