-
Notifications
You must be signed in to change notification settings - Fork 156
Clarify case-insensitive treatment of ARIA roles #2838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rahimabdi
wants to merge
2
commits into
main
Choose a base branch
from
rahim/clarify-case-insensitivity
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -870,7 +870,7 @@ <h2><abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr> Roles</h | |
| language semantics, there are no changes in the <abbr title="Document Object Model">DOM</abbr>, only in the <a class="termref">accessibility tree</a>. | ||
| </p> | ||
| <p> | ||
| User agents MUST use the first token in the sequence of tokens in the <a><code>role</code> attribute</a> value that matches the name of any non-abstract | ||
| User agents MUST use the first token in the sequence of tokens in the <a><code>role</code> attribute</a> value that is an [=ASCII case-insensitive=] match for the name of any non-abstract | ||
| <abbr title="Accessible Internet Application">WAI-ARIA</abbr> <a>role</a>. Refer to the section on <a><code>role</code> attribute</a> implementation in | ||
| <a href="#host_general_role">Host Languages</a> for further details. | ||
| </p> | ||
|
|
@@ -16352,7 +16352,7 @@ <h2><a>Role Attribute</a></h2> | |
| attribute value illegal in the host-language syntax; and | ||
| </li> | ||
| <li> | ||
| The first name literal of a non-abstract <abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr> role in the list of tokens in the <a><code>role</code> attribute</a> defines | ||
| The first [=ASCII case-insensitive=] name literal of a non-abstract <abbr title="Accessible Rich Internet Applications">WAI-ARIA</abbr> role in the list of tokens in the <a><code>role</code> attribute</a> defines | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this sentence should be replaced with the one above; "name literal" is just odd here. |
||
| the role according to which the user agent MUST process the element. User Agent processing for roles is defined in the | ||
| <cite><a href="" class="core-mapping">Core Accessibility API Mappings</a></cite> [[CORE-AAM-1.2]]. | ||
| </li> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there needs to be a matching change in the definition of the role attribute (Section 8.1) which has
Come to think of it, I think it would be better to remove this sentence here and only clarify this in the definition of the role attribute / Section 8.1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed @pkra, could it be specified in both places? I've updated the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just merged #2798 and section 8.1 is now the definitive place.
I strongly prefer not to duplicate normative statements - they get out of sync. Especially here, where there is little reason to look for a duplication all the way in Section 4 should we change something in Section 8.1.