Skip to content

fix: render core template variables for new notes #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
boabab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: render core template variables for new notes #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 39 additions & 15 deletions main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,21 +109,31 @@ function getCompareMethodItems(settings: TagFolderSettings) {

type NewNoteTemplateChoice = TFile;

function getCoreTemplatesFolder(app: App): string | null {
type CoreTemplatesOptions = {
folder?: string;
templateFolder?: string;
};

type CoreTemplatesPluginInstance = {
options?: CoreTemplatesOptions;
insertTemplate?: (template: TFile) => Promise<void> | void;
};

function getCoreTemplatesPlugin(app: App): CoreTemplatesPluginInstance | null {
const internalPlugins = (app as App & {
internalPlugins?: {
getPluginById?: (id: string) => {
instance?: {
options?: {
folder?: string;
templateFolder?: string;
};
};
instance?: CoreTemplatesPluginInstance;
};
};
}).internalPlugins;
const templatesPlugin = internalPlugins?.getPluginById?.("templates");
const folder = templatesPlugin?.instance?.options?.folder ?? templatesPlugin?.instance?.options?.templateFolder;

return internalPlugins?.getPluginById?.("templates")?.instance ?? null;
}

function getCoreTemplatesFolder(app: App): string | null {
const options = getCoreTemplatesPlugin(app)?.options;
const folder = options?.folder ?? options?.templateFolder;
if (!folder) return null;
const normalizedFolder = normalizePath(folder);
return normalizedFolder == "/" ? "" : normalizedFolder;
Expand Down Expand Up @@ -257,7 +267,7 @@ function normalizeNewNoteTemplatePath(templatePath: string) {
return normalizedPath == "/" ? "" : normalizedPath;
}

function renderNewNoteTemplate(template: string, expandedTagsAll: string[], expandedTags: string) {
function renderTagFolderTemplateVariables(template: string, expandedTagsAll: string[], expandedTags: string) {
const plainTags = expandedTagsAll.filter(e => !isSpecialTag(e));
const replacements: Record<string, string> = {
expandedTags,
Expand All @@ -272,6 +282,24 @@ function renderNewNoteTemplate(template: string, expandedTagsAll: string[], expa
return template.replace(/\{\{(expandedTags|tags|tagList|tagPath|tagName|tagsJson|tagsYaml)\}\}/g, (_, key: keyof typeof replacements) => replacements[key]);
}

async function insertNewNoteTemplate(app: App, note: TFile, template: TFile, expandedTagsAll: string[], expandedTags: string) {
const templatesPlugin = getCoreTemplatesPlugin(app);
const activeMarkdownView = app.workspace.getActiveViewOfType(MarkdownView);

if (templatesPlugin?.insertTemplate && activeMarkdownView?.file == note) {
await templatesPlugin.insertTemplate(template);
const editor = activeMarkdownView.editor;
editor.setValue(renderTagFolderTemplateVariables(editor.getValue(), expandedTagsAll, expandedTags));
return;
}

const templateContent = await app.vault.read(template);
const renderedTemplate = renderTagFolderTemplateVariables(templateContent, expandedTagsAll, expandedTags);
if (renderedTemplate.trim() != "") {
await app.vault.modify(note, renderedTemplate);
}
}

// Thank you @pjeby!
function onElement<T extends HTMLElement | Document>(el: T, event: string, selector: string, callback: CallableFunction, options: EventListenerOptions) {
//@ts-ignore
Expand Down Expand Up @@ -1428,11 +1456,7 @@ export default class TagFolderPlugin extends Plugin {
//@ts-ignore
const ww = await this.app.fileManager.createAndOpenMarkdownFile() as TFile;
if (selectedTemplate != null && selectedTemplate !== false) {
const template = await this.app.vault.read(selectedTemplate);
const renderedTemplate = renderNewNoteTemplate(template, expandedTagsAll, expandedTags);
if (renderedTemplate.trim() != "") {
await this.app.vault.modify(ww, renderedTemplate);
}
await insertNewNoteTemplate(this.app, ww, selectedTemplate, expandedTagsAll, expandedTags);
return;
}

Expand Down