Skip to content

feat(aggregation-layers): port HexagonLayer to WebGPU#10471

Merged
ibgreen merged 2 commits into
masterfrom
codex/webgpu-hexagon-layer
Jul 23, 2026
Merged

feat(aggregation-layers): port HexagonLayer to WebGPU#10471
ibgreen merged 2 commits into
masterfrom
codex/webgpu-hexagon-layer

Conversation

@ibgreen-openai

Copy link
Copy Markdown
Collaborator

Goal

Port HexagonLayer's cell renderer to WebGPU as a small, low-risk extraction from #10450, and expose the existing website example through the device tabs.

Changes

  • Added WGSL vertex/fragment shader support for HexagonCellLayer.
  • Added WGSL declarations for the hexagon uniforms and color-range texture bindings.
  • Kept the WebGL shader path aligned with master: the new WGSL source is only returned when the active device is WebGPU; the existing GLSL vertex shader and module setup remain unchanged for WebGL.
  • Passed the selected device into the 3D heatmap example and enabled its WebGL2/WebGPU tabs.

Website examples

Layer / example WebGPU aggregation WebGPU render path Status
HexagonLayer / 3D heatmap Existing CPU fallback when WebGLAggregator is unavailable HexagonCellLayer WGSL shader ✅ Works

The aggregation behavior is unchanged: WebGPU already selects the existing CPU aggregator because WebGLAggregator.isSupported(device) is false. This PR only ports the cell rendering path.

Validation

  • yarn build
  • yarn lint (passes; repository's existing warnings remain)
  • yarn test-headless test/modules/aggregation-layers/hexagon-layer.spec.ts
  • yarn test-website
  • Manual website check: selected the WebGPU tab on /examples/hexagon-layer; the example rendered and the browser console had no errors.

@ibgreen-openai
ibgreen-openai marked this pull request as ready for review July 23, 2026 14:30

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ccbeb67275

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/aggregation-layers/src/hexagon-layer/hexagon-cell-layer.wgsl.ts Outdated
@ibgreen
ibgreen merged commit 946ee26 into master Jul 23, 2026
3 checks passed
@ibgreen
ibgreen deleted the codex/webgpu-hexagon-layer branch July 23, 2026 18:52
@ibgreen-openai

ibgreen-openai commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

Review follow-up: the reviewer thread is addressed and resolved in e7aefda. Local build, lint, and focused HexagonLayer tests passed. GitHub CI is green, and the PR is approved and mergeable; safe to merge from review and CI standpoint.

@ibgreen-openai ibgreen-openai mentioned this pull request Jul 23, 2026
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants