[codex] Remove COORDINATE_SYSTEM.IDENTITY alias#10376
Open
charlieforward9 wants to merge 3 commits into
Open
Conversation
charlieforward9
marked this pull request as ready for review
June 13, 2026 07:00
Collaborator
|
Let's hold on merging while we focus master on 9.4 betas |
Member
Author
|
@copilot resolver los conflictos de combinación en esta rama. |
Contributor
Merged |
ibgreen-openai
approved these changes
Jul 17, 2026
| return new IconLayer({ | ||
| id: 'text', | ||
| coordinateSystem: COORDINATE_SYSTEM.IDENTITY, | ||
| coordinateSystem: COORDINATE_SYSTEM.CARTESIAN, |
Collaborator
There was a problem hiding this comment.
Nit: I believe that we are using string constants now for the coordinateSystem prop (so that apps don't have to import COORDINATE_SYSTEM, the enum values should be deprecated and avoided in code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Remove the deprecated
COORDINATE_SYSTEM.IDENTITYcompatibility alias for the v10 cleanup.Changes
Object.defineProperty(COORDINATE_SYSTEM, 'IDENTITY', ...)getter and its warning-onlylogimport.COORDINATE_SYSTEM.CARTESIAN.Documentation
COORDINATE_SYSTEM.IDENTITYhas been removed; useCOORDINATE_SYSTEM.CARTESIANinstead.Validation
yarn test-headless test/modules/core/shaderlib/project/project-functions.spec.ts test/modules/core/shaderlib/project/viewport-uniforms.spec.ts test/modules/mesh-layers/utils.spec.ts