Skip to content

fix(lang): add missing Japanese (ja) translation for "Playing in Picture-in-Picture"#9209

Open
greymoth-jp wants to merge 1 commit into
videojs:mainfrom
greymoth-jp:lang-ja-pip-playing
Open

fix(lang): add missing Japanese (ja) translation for "Playing in Picture-in-Picture"#9209
greymoth-jp wants to merge 1 commit into
videojs:mainfrom
greymoth-jp:lang-ja-pip-playing

Conversation

@greymoth-jp

Copy link
Copy Markdown

lang/en.json has the string "Playing in Picture-in-Picture", but lang/ja.json was missing it. It was added in #8113 (document picture-in-picture support), which updated en.json and de.json but not the Japanese file, so the string falls back to English for Japanese users.

This adds the Japanese translation, keeping the wording consistent with the existing PiP entries already in ja.json ("Picture-in-Picture" -> "ピクチャーインピクチャー", "Exit Picture-in-Picture" -> "ピクチャーインピクチャー機能の終了"). The meaning matches the German string added in the same PR ("Wird im Bild-im-Bild-Modus wiedergegeben").

After this change ja.json covers every key present in en.json.

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.14%. Comparing base (81b3cb4) to head (a4f4db9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9209      +/-   ##
==========================================
- Coverage   84.78%   84.14%   -0.64%     
==========================================
  Files         120      120              
  Lines        8167     8167              
  Branches     1967     1967              
==========================================
- Hits         6924     6872      -52     
- Misses       1243     1295      +52     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants