fix(player): guard against disposed tech in handleTechSourceset_ callback#9204
Open
okxint wants to merge 1 commit into
Open
fix(player): guard against disposed tech in handleTechSourceset_ callback#9204okxint wants to merge 1 commit into
okxint wants to merge 1 commit into
Conversation
…back
The any(['sourceset', 'loadstart']) listener is registered asynchronously.
If the tech is disposed before the loadstart event fires, this.tech_ is
false and this.lastSource_ may no longer be valid, causing errors when
calling techGet_('currentSrc') or writing to lastSource_.tech.
Add early-return guards: skip the callback body if this.tech_ is falsy,
and only update lastSource_.tech when lastSource_ itself still exists.
Fixes videojs#9187
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
loadstartasync callback inhandleTechSourceset_could fire after the tech was disposed, causing it to write tothis.tech_orthis.lastSource_.techon a dead object. Added an early return guard for!this.tech_and a null check onthis.lastSource_before writing.Closes #9187