fix: sync keymod flags with SDL3 (add LEVEL5, rename RESERVED to SCROLL)#417
Merged
Conversation
revmischa
changed the title
revmischa
approved these changes
Jul 21, 2026
revmischa
left a comment
revmischa
left a comment
Member
There was a problem hiding this comment.
Correct against the SDL3 keymod docs. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some keymod where missing from the sdl3 doc.
This result in the following result: if the user hit Scroll lock and call keyboard.mod_state(), the:
results in a panic.
This sync the code with the sdl3 doc at https://wiki.libsdl.org/SDL3/SDL_Keymod