Skip to content

Fix gpu-particles examples with new enums#202

Merged
revmischa merged 1 commit into
vhspace:masterfrom
florianvazelle:fix-gpu-particles
Jul 28, 2025
Merged

Fix gpu-particles examples with new enums#202
revmischa merged 1 commit into
vhspace:masterfrom
florianvazelle:fix-gpu-particles

Conversation

@florianvazelle

Copy link
Copy Markdown
Contributor

Hi @revmischa, just to respond to your comment #199 (comment)

There was a conflict between two of my PRs 😅

I fix the example in this PR, using the new enumeration added in #200

@florianvazelle

florianvazelle commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

To be clear, as in #158, #200 has introduced breaking changes to the relevant enums. I switch names to uppercase, because they become constants.

To avoid this kind of situation in the future, maybe we should test the build of examples in pull requests?

@revmischa

Copy link
Copy Markdown
Member

yeah there's plenty of room for improvement in the CI!

@revmischa
revmischa merged commit c0fae02 into vhspace:master Jul 28, 2025
3 checks passed
@florianvazelle
florianvazelle deleted the fix-gpu-particles branch July 29, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants