Skip to content

fix(discord): restore forwarded attachment downloads - #800

Open
onmax wants to merge 2 commits into
vercel:mainfrom
onmax:fix/discord-forwarded-attachment-data
Open

fix(discord): restore forwarded attachment downloads#800
onmax wants to merge 2 commits into
vercel:mainfrom
onmax:fix/discord-forwarded-attachment-data

Conversation

@onmax

@onmax onmax commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Discord inbound messages created attachment objects without fetchData, so consumers could not download audio or other attachments. The omission affected forwarded Gateway webhooks, REST and history parsing, and direct Discord.js Gateway messages.

Route attachments from all three inbound paths through the adapter's existing rehydrateAttachment() implementation. Existing parser and Gateway tests now assert that the resulting attachments are downloadable.

Test plan

  • pnpm validate
  • pnpm --filter @chat-adapter/discord test — 278 tests passing
  • pnpm --filter @chat-adapter/discord typecheck
  • pnpm --filter @chat-adapter/discord build

Checklist

  • All commits are signed and verified
  • All commits are signed off for the DCO (git commit -s)
  • pnpm validate passes
  • Changeset added
  • Documentation updated (N/A — no public API or configuration change)

Signed-off-by: onmax <maximogarciamtnez@gmail.com>
@onmax
onmax requested a review from a team as a code owner August 8, 2026 09:42
@vercel

vercel Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

@onmax is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

Direct Gateway (handleGatewayMessage) and REST (parseDiscordMessage) attachment paths build attachments without fetchData, so consumers cannot download attachments received through those paths.

Fix on Vercel

Signed-off-by: onmax <maximogarciamtnez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant