Deduplicate repeated Telegram webhook updates - #799
Open
onmax wants to merge 1 commit into
Open
Conversation
Signed-off-by: onmax <maximogarciamtnez@gmail.com>
Contributor
|
@onmax is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Telegram retries webhook deliveries after non-2xx responses, and its
update_idfield is explicitly intended for ignoring repeated updates. The Telegram adapter previously routed every webhook delivery independently.This change atomically claims each integer
update_idthrough the configuredStateAdapterbefore routing the update. Repeated deliveries return 200 without reaching bot handlers, while state failures return 503 without dispatching so Telegram can retry. Updates without an integerupdate_idkeep their existing behavior, and polling remains unchanged.Claims expire after 24 hours because Telegram retains incoming updates for no longer than 24 hours. This is a bounded retention choice, not a documented retry timeout. Cross-instance deduplication requires shared durable state; in-memory state only protects one process. The change provides webhook-delivery idempotency, not end-to-end exactly-once handler completion.
Telegram contract: Update and setWebhook.
Test plan
pnpm --filter @chat-adapter/telegram testpnpm --filter @chat-adapter/telegram typecheckpnpm checkpnpm konsistentTURBO_CONCURRENCY=1 pnpm validateRegression coverage verifies sequential and concurrent repeated deliveries, distinct update IDs, missing update IDs, duplicate 200 responses, and state-failure retry behavior. GitHub CI also passes on Node 22 and Node 24.
Checklist
git commit -s)pnpm validatepasses