fix(packaging): use sysconfig environment file in RPMs (#26076) - #26121
Open
inflatador wants to merge 2 commits into
Open
fix(packaging): use sysconfig environment file in RPMs (#26076)#26121inflatador wants to merge 2 commits into
inflatador wants to merge 2 commits into
Conversation
…26076) In RHEL-based Linux distros, service specific environment variable files typically live in /etc/sysconfig (as opposed to /etc/default in Debian). Vector's RPM currently uses the Debian path in its systemd unit file, which can lead to config not being loaded properly. Avoid this by switching to the RHEL convention.
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0411cef8ea
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Author
|
I have read the CLA Document and I hereby sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In RHEL-based Linux distros, service specific environment variable files typically live in /etc/sysconfig (as opposed to /etc/default in Debian).
Vector's RPM currently uses the Debian path in its systemd unit file, which can lead to config not being loaded properly. Avoid this by switching to the RHEL convention.
References
Closes: #26076
Vector configuration
N/A
How did you test this PR?
/etc/default/vectorto/etc/sysconfig/vector/etc/systemd/system/vector.service.d/vector-envvars.confwith the following content:4)Reload systemd
systemctl daemon-reload5) Restart the vector server
systemctl restart vector.service6) Verify the service starts cleanly
systemctl status vector.service7)Verify the service is using your override
systemctl cat vector.serviceIs this a breaking change?
Does this PR include user facing changes?
Y
no-changeloglabel to this PR.