Skip to content

fix release.yaml - #3616

Open
datelier wants to merge 1 commit into
mainfrom
fix/ci/release
Open

fix release.yaml#3616
datelier wants to merge 1 commit into
mainfrom
fix/ci/release

Conversation

@datelier

@datelier datelier commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

Create release failed with 403 Resource not accessible by integration, so the v1.8.0 tag was pushed but no GitHub Release was created.

softprops/action-gh-release@v2 reads its token input, which defaults to ${{ github.token }}.
The env: GITHUB_TOKEN was therefore never used, and the job token - limited to contents: read - was used instead.

Passing the PAT through with.token so the step authenticates as the same identity as Create release tag above it.
Granting contents: write instead would also fix the 403, but the release would then be created by GITHUB_TOKEN, which does not trigger build-binaries.yaml (on: release: type: [created]).

Related Issue

Versions

  • Vald Version: v1.7.17
  • Go Version: v1.26.6
  • Rust Version: v1.97.1
  • Docker Version: v29.7.2
  • Kubernetes Version: v1.36.3
  • Helm Version: v4.2.4
  • NGT Version: v2.7.4
  • Faiss Version: v1.15.0

Checklist

Special notes for your reviewer

@vdaas-ci

Copy link
Copy Markdown
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-v2 - run E2E deploy & integration test (tests/v2/e2e)

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5e63a847-99ab-424f-9dc8-bd419d99701f

📥 Commits

Reviewing files that changed from the base of the PR and between 02b97d9 and 52902c7.

📒 Files selected for processing (1)
  • .github/workflows/release.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The release workflow now passes secrets.DISPATCH_TOKEN through the release action’s token input. It no longer sets GITHUB_TOKEN as an environment variable.

Changes

Release workflow

Layer / File(s) Summary
Release action token wiring
.github/workflows/release.yaml
The workflow replaces the GITHUB_TOKEN environment setting with the release action’s token input using secrets.DISPATCH_TOKEN.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 52902

This is a localized release-workflow change with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: kpango

Poem

A token takes its proper place,
Passed through the action’s input space.
The workflow runs clear and bright,
With secrets wired just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the changed workflow file and indicates a fix, but it does not specify the token input change.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci/release

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants