-
Notifications
You must be signed in to change notification settings - Fork 95
Update libs dependency #3612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libs dependency #3612
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,7 +45,7 @@ jobs: | |
| if: ${{ !contains(fromJSON('["cloudflare-workers-and-pages", "coderabbitai", "vdaas-ci", "all-contributors"]'), github.event.comment.user.login) }} | ||
| runs-on: ubuntu-slim | ||
| steps: | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/checkout@v7 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: ./.github/actions/dump-context | ||
|
|
@@ -152,7 +152,7 @@ jobs: | |
| env: | ||
| GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }} | ||
| BRANCH: ${{ steps.check_comments_rebase.outputs.BRANCH_NAME }} | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/checkout@v7 | ||
| if: steps.check_comments_rebase.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true' | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -163,7 +163,7 @@ jobs: | |
| git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
| - name: Automatic Rebase | ||
| if: steps.check_comments_rebase.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true' | ||
| uses: cirrus-actions/rebase@b87d48154a87a85666003575337e27b8cd65f691 # 1.8 | ||
| uses: cirrus-actions/rebase@1.8 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- target workflow ---'
sed -n '130,190p' .github/workflows/chatops.yaml
printf '%s\n' '--- workflow permissions and action references ---'
rg -n '^(permissions:| permissions:| permissions:| uses:| uses:| uses:| uses:|uses:)' .github/workflows/chatops.yaml || true
printf '%s\n' '--- repository metadata ---'
curl -LfsS 'https://api.github.com/repos/cirrus-actions/rebase' |
jq '{full_name, archived, default_branch, pushed_at, html_url}'Repository: vdaas/vald Length of output: 2937 🌐 Web query:
💡 Result: The GitHub repository cirrus-actions/rebase was archived by its owner on May 7, 2024 [1][2]. As a result, the repository is now read-only [1][3]. This action, which was designed to automatically rebase pull requests via comments (e.g., /rebase), is no longer actively maintained [4][5]. Users should be aware that the repository remains available for reference but will not receive further updates or issue resolutions [1][2]. Citations:
🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- rebase job header ---'
sed -n '85,175p' .github/workflows/chatops.yaml
printf '%s\n' '--- all action references ---'
rg -n 'uses:' .github/workflows/chatops.yaml
printf '%s\n' '--- repository references and documentation ---'
rg -n -i 'cirrus-actions/rebase|automatic rebase|rebase action|DISPATCH_TOKEN' . --glob '!vendor/**' --glob '!node_modules/**' | head -100Repository: vdaas/vald Length of output: 4477 Replace the archived rebase action. 🧰 Tools🪛 zizmor (1.29.0)[error] 166-166: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy) (unpinned-uses) [warning] 166-166: action or reusable workflow from archived repository (archived-uses): repository is archived (archived-uses) 🤖 Prompt for AI AgentsSource: Linters/SAST tools |
||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }} | ||
| - name: Failure comment | ||
|
|
@@ -228,15 +228,15 @@ jobs: | |
| env: | ||
| GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }} | ||
| PR_AUTHOR: ${{ github.event.issue.user.login }} | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/checkout@v7 | ||
| if: steps.check_comments_gen_test.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true' | ||
| with: | ||
| persist-credentials: false | ||
| fetch-depth: 0 | ||
| - name: set git config | ||
| run: | | ||
| git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
| - uses: crazy-max/ghaction-import-gpg@2dc316deee8e90f13e1a351ab510b4d5bc0c82cd # v7.0.0 | ||
| - uses: crazy-max/ghaction-import-gpg@v7 | ||
| if: steps.check_comments_gen_test.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true' | ||
| with: | ||
| gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
|
|
@@ -337,7 +337,7 @@ jobs: | |
| $API_URL | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.DISPATCH_TOKEN }} | ||
| - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
| - uses: actions/checkout@v7 | ||
| if: steps.check_comments_format.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true' | ||
| with: | ||
| persist-credentials: false | ||
|
|
@@ -346,7 +346,7 @@ jobs: | |
| - name: set git config | ||
| run: | | ||
| git config --global --add safe.directory ${GITHUB_WORKSPACE} | ||
| - uses: crazy-max/ghaction-import-gpg@2dc316deee8e90f13e1a351ab510b4d5bc0c82cd # v7.0.0 | ||
| - uses: crazy-max/ghaction-import-gpg@v7 | ||
| if: steps.check_comments_format.outputs.BOOL_TRIGGERED == 'true' && steps.check_permissions.outputs.EXECUTABLE == 'true' | ||
| with: | ||
| gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }} | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Pin external GitHub Actions to immutable commit SHAs. The affected workflows and actions use mutable references such as
@master, version tags, and@1.8, allowing upstream changes without a repository change. Replace each external reference with an audited 40-character commit SHA and retain the release version in a comment.📍 Affects 4 files
.github/actions/scan-docker-image/action.yaml#L31-L39(this comment).github/workflows/_detect-ci-container.yaml#L51-L51.github/workflows/backport.yaml#L34-L34.github/workflows/check-conflict.yaml#L26-L26🤖 Prompt for AI Agents
Sources: Path instructions, Linters/SAST tools