feat/apis: add algorithm-specific payload options by Matts966 · Pull Request #3589 · vdaas/vald

Matts966 · 2026-08-05T04:32:24Z

Summary

extract the shared gRPC/protobuf interface changes from feature/agent/zvec-any-options
add algorithm-specific google.protobuf.Any options to the payload API
include regenerated Go, Rust, Swagger, and API documentation artifacts
exclude the zvec runtime implementation, Helm configuration, and CI changes

Verification

ran make proto/all
buf generate completed successfully
applied the repository proto/replace transformations in smaller batches because macOS xargs exceeded its command-line length limit

Stacked PR

feature/agent/zvec-any-options is based on this branch.

coderabbitai · 2026-08-05T04:32:32Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c6c91365-b759-4e1b-b8aa-07d6b4032b7c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

vdaas-ci · 2026-08-05T04:32:34Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
🔚 2️⃣ 🔚 /label actions/e2e-v2 - run E2E deploy & integration test (tests/v2/e2e)

Matts966 · 2026-08-07T06:44:58Z

/format

vdaas-ci · 2026-08-07T06:46:26Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

cloudflare-workers-and-pages · 2026-08-07T06:51:29Z

Deploying vald with Cloudflare Pages

Latest commit:	`ee05196`
Status:	✅ Deploy successful!
Preview URL:	https://6c4ed128.vald.pages.dev
Branch Preview URL:	https://feature-grpc-common-any-args.vald.pages.dev

View logs

vdaas-ci · 2026-08-07T06:57:24Z

[FORMAT] Failed to format.

Matts966 · 2026-08-12T03:10:14Z

/format

vdaas-ci · 2026-08-12T03:12:19Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

Matts966 · 2026-08-12T03:19:04Z

/format

vdaas-ci · 2026-08-12T03:22:10Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

vdaas-ci · 2026-08-12T03:22:33Z

[FORMAT] Failed to format.

Signed-off-by: Vdaas CI <vald@vdaas.org>

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 11, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28238 in e7bf077

case 11:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 12, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28257 in e7bf077

case 12:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 13, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28276 in e7bf077

case 13:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 14, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28295 in e7bf077

case 14:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 15, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28314 in e7bf077

case 15:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 16, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28333 in e7bf077

case 16:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 17, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28352 in e7bf077

case 17:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 18, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28371 in e7bf077

case 18:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 19, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28390 in e7bf077

case 19:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 20, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28409 in e7bf077

case 20:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 21, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28428 in e7bf077

case 21:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 22, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28439 in e7bf077

case 22:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 23, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28450 in e7bf077

case 23:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 24, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28461 in e7bf077

case 24:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 25, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28472 in e7bf077

case 25:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 26, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28483 in e7bf077

case 26:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 27, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28494 in e7bf077

case 27:

🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 28, in detected (mnd)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 28505 in e7bf077

case 28:

🚫 [golangci] _{reported by reviewdog 🐶}
ST1006: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (staticcheck)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 2864 in e7bf077

func (this *ZVec_DocumentOptions) EqualVT(that *ZVec_DocumentOptions) bool {

🚫 [golangci] _{reported by reviewdog 🐶}
ST1006: receiver name should be a reflection of its identity; don't use generic names such as "this" or "self" (staticcheck)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 2885 in e7bf077

func (this *ZVec_DocumentOptions) EqualMessageVT(thatMsg proto.Message) bool {

🚫 [golangci] _{reported by reviewdog 🐶}
unnecessary conversion (unconvert)

vald/apis/grpc/v1/payload/payload_vtproto.pb.go

Line 6634 in e7bf077

binary.LittleEndian.PutUint32(dAtA[i:], uint32(f1))

github-actions · 2026-08-12T03:41:40Z

@@ -22893,7 +24373,7 @@ func (m *Object_VectorRequest) UnmarshalVT(dAtA []byte) error {
 	return nil
 }

-func (m *Object_Distance) UnmarshalVT(dAtA []byte) error {
+func (m *Remove_MultiRequest) UnmarshalVT(dAtA []byte) error {


🚫 [golangci] _{reported by reviewdog 🐶}
24376-24546 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:31703-31873 (dupl)

github-actions · 2026-08-12T03:41:40Z

@@ -24468,7 +25664,7 @@ func (m *Object_Location) UnmarshalVT(dAtA []byte) error {
 	return nil
 }

-func (m *Object_StreamLocation) UnmarshalVT(dAtA []byte) error {
+func (m *Object_Timestamp) UnmarshalVT(dAtA []byte) error {


🚫 [golangci] _{reported by reviewdog 🐶}
25667-25768 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:31072-31173 (dupl)

github-actions · 2026-08-12T03:41:40Z

 		}
 		switch fieldNum {
+		case 1:


🚫 [golangci] _{reported by reviewdog 🐶}
26315-26355 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:26613-26653 (dupl)

github-actions · 2026-08-12T03:41:41Z

 		}
 		switch fieldNum {
+		case 1:


🚫 [golangci] _{reported by reviewdog 🐶}
26613-26653 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:26901-26941 (dupl)

github-actions · 2026-08-12T03:41:41Z

@@ -28046,7 +31069,7 @@ func (m *Info_ResourceStats) UnmarshalVT(dAtA []byte) error {
 	return nil
 }

-func (m *Info_CgroupStats) UnmarshalVT(dAtA []byte) error {
+func (m *Info_ServicePort) UnmarshalVT(dAtA []byte) error {


🚫 [golangci] _{reported by reviewdog 🐶}
31072-31173 lines are duplicate of apis/grpc/v1/payload/payload_vtproto.pb.go:32097-32198 (dupl)

github-actions · 2026-08-12T03:41:41Z

+					break
+				}
+			}
+		case 6:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 6, in detected (mnd)

github-actions · 2026-08-12T03:41:41Z

+					break
+				}
+			}
+		case 7:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 7, in detected (mnd)

github-actions · 2026-08-12T03:41:41Z

+					break
+				}
+			}
+		case 8:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 8, in detected (mnd)

github-actions · 2026-08-12T03:41:41Z

+					break
+				}
+			}
+		case 9:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 9, in detected (mnd)

github-actions · 2026-08-12T03:41:41Z

+					break
+				}
+			}
+		case 10:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 10, in detected (mnd)

Matts966 · 2026-08-12T04:10:11Z

/format

vdaas-ci · 2026-08-12T04:11:27Z

[FORMAT] Updating license headers and formatting go codes triggered by Matts966.

Signed-off-by: Vdaas CI <vald@vdaas.org>

github-actions · 2026-08-12T04:28:31Z

+					break
+				}
+			}
+		case 11:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 11, in detected (mnd)

github-actions · 2026-08-12T04:28:31Z

+					break
+				}
+			}
+		case 12:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 12, in detected (mnd)

github-actions · 2026-08-12T04:28:31Z

+					break
+				}
+			}
+		case 13:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 13, in detected (mnd)

github-actions · 2026-08-12T04:28:31Z

+					break
+				}
+			}
+		case 14:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 14, in detected (mnd)

github-actions · 2026-08-12T04:28:31Z

+					break
+				}
+			}
+		case 15:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 15, in detected (mnd)

github-actions · 2026-08-12T04:28:32Z

+			v = uint64(binary.LittleEndian.Uint64(dAtA[iNdEx:]))
+			iNdEx += 8
+			m.MeanEdgeLength = float64(math.Float64frombits(v))
+		case 24:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 24, in detected (mnd)

github-actions · 2026-08-12T04:28:32Z

+			v = uint64(binary.LittleEndian.Uint64(dAtA[iNdEx:]))
+			iNdEx += 8
+			m.MeanEdgeLengthFor10Edges = float64(math.Float64frombits(v))
+		case 25:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 25, in detected (mnd)

github-actions · 2026-08-12T04:28:32Z

+			v = uint64(binary.LittleEndian.Uint64(dAtA[iNdEx:]))
+			iNdEx += 8
+			m.MeanIndegreeDistanceFor10Edges = float64(math.Float64frombits(v))
+		case 26:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 26, in detected (mnd)

github-actions · 2026-08-12T04:28:32Z

+			v = uint64(binary.LittleEndian.Uint64(dAtA[iNdEx:]))
+			iNdEx += 8
+			m.MeanNumberOfEdgesPerNode = float64(math.Float64frombits(v))
+		case 27:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 27, in detected (mnd)

github-actions · 2026-08-12T04:28:32Z

+			v = uint64(binary.LittleEndian.Uint64(dAtA[iNdEx:]))
+			iNdEx += 8
+			m.C1Indegree = float64(math.Float64frombits(v))
+		case 28:


🚫 [golangci] _{reported by reviewdog 🐶}
Magic number: 28, in detected (mnd)

feat/apis: add algorithm-specific payload options

5463a0b

Matts966 mentioned this pull request Aug 5, 2026

feat/apis: add algorithm-specific payload options #3588

Closed

fix(rust): initialize insert options in upsert

dda2730

Matts966 added 2 commits August 12, 2026 12:18

fix(apis): preserve timestamp operator names

a4ea979

Merge branch 'main' into feature/grpc/common-any-args

0f69ced

🤖 Update license headers / Format go codes and yaml files

e7bf077

Signed-off-by: Vdaas CI <vald@vdaas.org>

github-actions Bot added size/XL and removed size/XL labels Aug 12, 2026

github-actions Bot reviewed Aug 12, 2026

View reviewed changes

🤖 Update license headers / Format go codes and yaml files

22bac3a

Signed-off-by: Vdaas CI <vald@vdaas.org>

github-actions Bot added size/XL and removed size/XL labels Aug 12, 2026

github-actions Bot reviewed Aug 12, 2026

View reviewed changes

Merge branch 'main' into feature/grpc/common-any-args

ee05196

github-actions Bot added size/XL and removed size/XL labels Aug 18, 2026

Uh oh!

Conversation

Matts966 commented Aug 5, 2026

Summary

Verification

Stacked PR

Uh oh!

coderabbitai Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

vdaas-ci commented Aug 5, 2026

Uh oh!

Matts966 commented Aug 7, 2026

Uh oh!

vdaas-ci commented Aug 7, 2026

Uh oh!

cloudflare-workers-and-pages Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying vald with Cloudflare Pages

Uh oh!

vdaas-ci commented Aug 7, 2026

Uh oh!

Matts966 commented Aug 12, 2026

Uh oh!

vdaas-ci commented Aug 12, 2026

Uh oh!

Matts966 commented Aug 12, 2026

Uh oh!

vdaas-ci commented Aug 12, 2026

Uh oh!

vdaas-ci commented Aug 12, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Matts966 commented Aug 12, 2026

Uh oh!

vdaas-ci commented Aug 12, 2026

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 12, 2026

coderabbitai Bot commented Aug 5, 2026 •

edited

Loading

cloudflare-workers-and-pages Bot commented Aug 7, 2026 •

edited

Loading