test: cover cell content attach and detach on column add/remove#12181
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
There was a problem hiding this comment.
Reviewed the changes — left 1 comment.
| Finding | |
|---|---|
| 🧹 | The three should remove ... cell content tests duplicate boilerplate instead of reusing the forEach-over-sections pattern already in this file. |
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
web-padawan
reviewed
Jul 17, 2026
| let content; | ||
|
|
||
| beforeEach(() => { | ||
| if (sectionName === 'header') { |
Member
There was a problem hiding this comment.
nit: could use switch (sectionName) here with body as default I guess.
web-padawan
approved these changes
Jul 17, 2026
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0-alpha6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a column is removed, the grid also removes the column's
<vaadin-grid-cell-content>elements from its light DOM, and adds them back when the column is added again. This behavior wasn't covered by tests for header and footer cells. The declarative header/footer rendering refactor changes how header and footer cell content is managed, so this adds tests to lock in the current behavior first.Extracted from #12134
Part of #10789
🤖 Generated with Claude Code