test: re-enable undefined-size grid scroll regression checks#9760
Merged
Conversation
Re-enable the disabled steps in the ItemCountUnknownGridIT scroll-to-end test and drop the stale #1038 / #9166 FIXME. The grid no longer fetches extra earlier ranges after the item count shrinks from an estimate to the real size, so assert that scrolling around after the size is adjusted keeps the size and does not trigger unnecessary fetches. Part of #9166 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
vaadin-review-bot
left a comment
vaadin-review-bot
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the changes — left 1 comment.
| Finding | |
|---|---|
| 👀 | The re-enabled regression assertion uses a coarse total-fetch-count bound that may not actually fail on the pre-fix behavior it targets. |
Replace the total fetch-count ceiling with a check that scrolling after the size is adjusted only fetches the visited viewports, never the ranges in between. This catches an off-viewport refetch regardless of count and avoids flakiness from viewport variance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
vursen
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Re-enable the disabled steps in the ItemCountUnknownGridIT scroll-to-end test and drop the stale FIXME. The grid no longer fetches extra earlier ranges after the item count shrinks from an estimate to the real size, so assert that scrolling around after the size is adjusted keeps the size and does not trigger unnecessary fetches.
Related to vaadin/flow#9166
Type of change