refactor!: emit form filler field value events per field#9593
Merged
tomivirkki merged 5 commits intoJul 22, 2026
Conversation
… refactor-emit-form-filler-field-value-events-per-field # Conflicts: # vaadin-ai-components-flow-parent/vaadin-ai-components-flow/src/main/java/com/vaadin/flow/component/ai/form/FieldValueChange.java
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tomivirkki
self-requested a review
July 21, 2026 13:24
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A field added to the form during the turn produced a spurious (null -> empty) change event and a null oldValue on real changes. Also keep event values serializable and correct since tags to 25.3. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
tomivirkki
approved these changes
Jul 21, 2026
|
tomivirkki
deleted the
refactor-emit-form-filler-field-value-events-per-field
branch
July 22, 2026 08:22
Collaborator
|
This ticket/PR has been released with Vaadin 25.3.0-alpha6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR
addFieldValueChangedListener->addFieldValueChangeListener)FieldValueChangeListenerand event classFieldValueChangeEventFieldValueChangeEventper changed fieldBased on Form Filler DX test session findings.
Warning
Breaking change.
addFieldValueChangedListener(SerializableConsumer<List<FieldValueChange>>)is replaced byaddFieldValueChangeListener(FieldValueChangeListener). The listener now fires once per changed field with aFieldValueChangeEventinstead of once per turn with aList<FieldValueChange>. TheFieldValueChangerecord is removed.No related issue.
Type of change
Checklist