ci: Change the spell detection strategy#13472
Open
sylvestre wants to merge 2 commits into
Open
Conversation
The local hook was language: system and exited 0 with a "cspell not found, skipping spell check" message when cspell was absent from PATH, which pre-commit reported as "Passed". In practice nobody had cspell installed, so spelling was only ever checked in CI. Use the upstream cspell-cli hook instead: it is language: node, so pre-commit installs cspell itself and cannot silently skip. Pin language_version since cspell v10 requires node >= 22.18.
Now that cspell runs locally via pre-commit, Style/spelling only annotates unknown words rather than blocking the merge. Also fix the pre_commit job, which ran "pre-commit run" without --all-files and so matched zero files on a fresh checkout. Skip the hooks already covered by the Style/format and Style/lint jobs, and drop the npm install of cspell now that the hook provides its own.
|
GNU testsuite comparison: |
cakebaker
reviewed
Jul 21, 2026
| # Spelling is enforced locally by the cspell pre-commit hook, where it is | ||
| # cheap to fix. Here it is advisory: unknown words show up as annotations | ||
| # on the diff instead of blocking the merge. | ||
| STYLE_FAIL_ON_FAULT: false |
Contributor
There was a problem hiding this comment.
Hm, is this job still necessary if it never fails?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think we wasted too much time on typo detection. Let's avoid failing the build just for that