who: fix panic in -q/--count on stdout write error#13452
Open
koopatroopa787 wants to merge 2 commits into
Open
who: fix panic in -q/--count on stdout write error#13452koopatroopa787 wants to merge 2 commits into
koopatroopa787 wants to merge 2 commits into
Conversation
`who -q` printed the user list and count with `println!`, which aborts on a write error (e.g. when output is redirected to /dev/full). Replace both calls with `writeln!` against a locked stdout handle so errors are propagated to the caller and reported gracefully. Fixes uutils#13388
|
GNU testsuite comparison: |
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
who -q(--count) prints a user list and a count line usingprintln!, which aborts (panics) if stdout write fails — e.g. when output is redirected to/dev/full:Fix: replace the two
println!calls in theshort_listbranch ofWho::exec()withwriteln!on a locked stdout handle, so errors are propagated via?and reported gracefully.Fixes #13388
Changes
src/uu/who/src/platform/unix.rs: replaceprintln!withwriteln!(out, …)?for user list and count outputtests/by-util/test_who.rs: addtest_count_write_error(Linux only, via/dev/full) to confirm the error is reported rather than causing an abort