Skip to content

Fix Gemma3N/Gemma4 gradient_checkpointing_enable crash on positional kwargs #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oobabooga wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

Fix Gemma3N/Gemma4 gradient_checkpointing_enable crash on positional kwargs #6826

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b22520
Fix gradient_checkpointing_enable positional arg crash on Gemma3N/Gem…
oobabooga Jul 2, 2026
5b6733e
Merge branch 'main' into fix-gc-enable-reentrant
oobabooga Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions unsloth/models/vision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1889,8 +1889,9 @@ def _nonre_checkpoint(function, *args, **kwargs):
if "gemma3n" in _model_type.lower() or "gemma4" in _model_type.lower():
_original_gc_enable = model.gradient_checkpointing_enable

def _gc_enable_reentrant(**kwargs):
gc_kwargs = kwargs.get("gradient_checkpointing_kwargs", {}) or {}
def _gc_enable_reentrant(gradient_checkpointing_kwargs = None, **kwargs):
# TRL's disable_gradient_checkpointing re-enables this positionally; HF/PEFT/notebooks by keyword.
gc_kwargs = dict(gradient_checkpointing_kwargs or {})
gc_kwargs["use_reentrant"] = True
kwargs["gradient_checkpointing_kwargs"] = gc_kwargs
return _original_gc_enable(**kwargs)
Expand Down
Loading