Skip to content

Remove hardcoding montage in plot_butterfly; add underscore to montage name in get_label_pos - #448

Open
kbelgal02 wants to merge 2 commits into
unfoldtoolbox:mainfrom
kbelgal02:butterfly
Open

kbelgal02 wants to merge 2 commits into
unfoldtoolbox:mainfrom
kbelgal02:butterfly

Conversation

@kbelgal02

Copy link
Copy Markdown
Contributor

Also added corresponding tests

@codecov

codecov Bot commented Aug 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (9860b3a) to head (4f9ebb1).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   90.32%   90.63%   +0.31%     
==========================================
  Files          27       27              
  Lines        1467     1473       +6     
==========================================
+ Hits         1325     1335      +10     
+ Misses        142      138       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vladdez

vladdez commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

If i will write

    montage = get_montage("biosemi16")
    plot_butterfly(randn(length(montage.labels), 100); montage = "biosemi16")

the head disappears. Is it a bug or feature?
I think it is more bug. We need labels to extracts some channels from a montage, but if you want the full montage you kinda dont need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants