Skip to content

chore: update dumi 1 bundler ad - #2372

Draft
fireairforce wants to merge 1 commit into
1.xfrom
zoomdong/update-dumi1-utoopack-ad
Draft

chore: update dumi 1 bundler ad#2372
fireairforce wants to merge 1 commit into
1.xfrom
zoomdong/update-dumi1-utoopack-ad

Conversation

@fireairforce

Copy link
Copy Markdown
Member

What changed

  • suppress the Mako advertisement inherited from Umi 3 when running dumi dev
  • replace it with an accurate migration hint for upgrading to dumi 2 and enabling utoopack: {}
  • preserve MAKO_AD=none as the opt-out for the replacement message

Why

dumi 1 depends on umi@^3.5.27, whose current 3.x dev command advertises Mako. dumi 1 cannot enable utoopack directly, so a literal bundler replacement would be misleading. The new message points users to dumi 2, where utoopack is supported.

User impact

dumi 1 users will no longer see the outdated Mako promotion. During dumi dev, they will instead see a link to the dumi 2 utoopack configuration guide.

Validation

  • isolated CLI test verifies the utoopack migration message is printed for dumi dev
  • isolated CLI test verifies MAKO_AD=none suppresses the message
  • Prettier check
  • ESLint check
  • git diff --check

A full dumi 1 build was not run because this checkout has dumi 2 dependencies installed; the changed CLI behavior was tested with the child process and module resolution stubbed.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying dumi with 聽Cloudflare Pages 聽Cloudflare Pages

Latest commit: cc8a819
Status:馃毇聽 Build failed.

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant