chore: update dumi 1 bundler ad - #2372
Draft
fireairforce wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dumi devutoopack: {}MAKO_AD=noneas the opt-out for the replacement messageWhy
dumi 1 depends on
umi@^3.5.27, whose current3.xdev command advertises Mako. dumi 1 cannot enable utoopack directly, so a literal bundler replacement would be misleading. The new message points users to dumi 2, where utoopack is supported.User impact
dumi 1 users will no longer see the outdated Mako promotion. During
dumi dev, they will instead see a link to the dumi 2 utoopack configuration guide.Validation
dumi devMAKO_AD=nonesuppresses the messagegit diff --checkA full dumi 1 build was not run because this checkout has dumi 2 dependencies installed; the changed CLI behavior was tested with the child process and module resolution stubbed.