Skip to content

feat: page-tab default tab supports internationalized interpolation #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wxh16144 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: page-tab default tab supports internationalized interpolation #1860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fdeced
feat: page-tab default tab prioritizes frontmatter title
Wxh16144 Aug 26, 2023
534cddb
chore: update
Wxh16144 Aug 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/client/theme-default/slots/ContentTabs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@ const ContentTabs: FC<IContentTabsProps> = ({
onChange,
}) => {
const intl = useIntl();
const { frontmatter: fm } = useRouteMeta();

// TODO: tab.Extra & tab.Action render

return Boolean(tabs?.length) ? (
<ul className="dumi-default-content-tabs">
<li onClick={() => onChange()} data-active={!key || undefined}>
<button type="button">
{intl.formatMessage({ id: 'content.tabs.default' })}
{fm.title || intl.formatMessage({ id: 'content.tabs.default' })}
</button>
</li>
{tabs!.map((tab) => (
Expand Down