Add CI test pipeline and Elasticsearch 7 setup with uv by DhavalGojiya · Pull Request #291 · ulgens/drf-haystack

DhavalGojiya · 2026-06-12T10:38:34Z

Description

Closes Issues: #249
Closes PR's: #226 and #189

Added support for Elasticsearch 7 in the package.
django-haystack supports up to Elasticsearch 7 version.

Other older Elasticsearch versions <7 have reached EOL (End of Life): see.

Summary

Removed obsolete test cases related to Django REST Framework versions below 3.7.
Removed tox.ini (super slow / unnecessary complexity)
Updated the test suite for Elasticsearch 7 compatibility.
Add uv support to manage workflows and project.
Added support for Python 3.8+ and the latest Python releases.
Removed Dockerfile (We are not using it, docker compose file did the every work)

Tests

Docker setup

DhavalGojiya · 2026-06-12T10:44:07Z

@ulgens
Finally, we did it
but it was so frustrating and difficult to get everything working properly. 🤧

ulgens · 2026-06-12T10:54:48Z

Congrats and thank you so much!

I can't promise an immediate review but I'll check it bit by bit when I have the time.

ulgens · 2026-06-13T07:42:21Z

+      matrix:
+        django-version: ["4.2.*"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14", "3.14t"]
+        elastic-version: ["7.17.29"]


Do we plan to broaden the elastic entry? How many majors - minors elastic have supported at a given time?

django-haystack (Primary dependency of this package) doesn't support Elasticsearch 8 or 9 yet.

All earlier Elasticsearch versions are already EOL. Elasticsearch 7 is also EOL, but it only reached EOL about four months ago, so it probably makes sense to keep testing against Elasticsearch 7 for now.

If django-haystack adds support for Elasticsearch 8 or 9 in the future, we can expand the test matrix accordingly.
More info here: https://endoflife.date/elasticsearch

ulgens · 2026-06-13T07:45:38Z

+      fail-fast: false
+      matrix:
+        django-version: ["4.2.*"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13", "3.14", "3.14t"]


4.2 doesn't support > Python 3.12 https://docs.djangoproject.com/en/4.2/faq/install/

Added a new comment.

ulgens · 2026-06-13T07:47:01Z

    { name = "Rolf Håvard Blindheim", email = "rhblind@gmail.com" },
    { name = "Ülgen Sarıkavak", email = "foss@ulgenwanders.net" },
 ]
-requires-python = ">=3.8,<3.11"


Please don't remove the upper limit. The project doesn't support all existing Python versions and not in a state that it can be installed with a new Python version when it's released.

I don't get this.
Also, how do we know which Python versions this project supports and which it doesn't, other than relying on the test case results?

The test cases pass for all available Python versions.

According to you, what upper limit can we set? Just < 3.11?

Maybe we can use < 3.15?

Currently, there are 7 client projects in our company using this drf-haystack package. Our 8th and 9th projects use Django 5.2, and because of the Django constraints of this package, we can't use drf-haystack in those projects.

We just copy the whole drf-haystack folder and use it as a normal Django app in the new projects that use Django 5.2 with Python 3.13 and everything working fine.

Also, how do we know which Python versions this project supports and which it doesn't, other than relying on the test case results?

Yep. Just match the tested versions.

The project may work fine for a particular setup, that's nice, but that doesn't translate to "it works" yet. Please keep the support delegations limited to the tested versions for now.

Let's go 🤞

ulgens · 2026-06-13T08:25:58Z

Merged

The branch will need a rebase - sorry.

DhavalGojiya · 2026-06-13T09:47:40Z

@ulgens
Also, can we just drop Python 3.8 and Python 3.9 support?

As you can see, in the Python 3.8 job matrix, the build backend is causing issues with some license key definition error.

I think it's more overhead and extra work that we're currently dealing with without any real benefit.
For now, we should not focus on supporting older Python versions.

ulgens · 2026-06-13T10:06:12Z

Dropping 3.8 - 3.9 sounds tempting but if we do that, we will have 0 backward compatibility with the next version, which I think we should fallback to as the very last resort.

The CI failure looks like an issue with uv - pyproject and I don't expect it to a require a complex solution.

ulgens · 2026-06-14T18:25:34Z


 BASE_DIR = Path(__file__).parent.resolve()

-SECRET_KEY = "NOBODY expects the Spanish Inquisition!"


To keep the diff smaller and easy to review, please don't include things that are not directly in the scope defined by the commit message. Same goes for DEFAULT_AUTO_FIELD and MIDDLEWARE_CLASSES changes. If they are needed for the PR, a separate commit with the explanation would be nice.

The correct Django settings variable name is MIDDLEWARE, not MIDDLEWARE_CLASSES.

The Django Auto Field setting is used to silence the many warnings related to auto-created primary keys that appear when running runserver or executing test cases.

Done :)

Added a new commit with a proper message explaining the middleware-related changes.

Reverted the secret key and Django Auto Field settings for now. will cover those changes in a separate PR.

ulgens · 2026-06-14T18:27:10Z

+def gdal_is_available():
+    """
+    Return True if GDAL is installed.
+
+    We can't import Point without the GDAL/GEOS libraries, so we just try it
+    and treat any failure as "not available". Used to skip the geo tests on
+    machines that don't have GDAL.
+    """
+    try:
+        from django.contrib.gis.geos import Point  # noqa: F401
+    except ImproperlyConfigured:
+        return False
+    return True


Did the old helper/utility have any issues?

The old init code are unnecessary and complex also not optimized along with some Django REST Framework if/else logic and Elasticsearch version extraction.

Also, the message says that the GOES library needs to be installed, but it actually requires GDAL, and GOES is installed automatically as a dependency of GDAL.

…session authentication middleware

DhavalGojiya · 2026-06-14T19:31:39Z

@ulgens

I think everything is clear now. 🫡

…it terminal output

DhavalGojiya · 2026-06-15T13:09:22Z

New change:
Add --quite-pull flag to Docker es setup to reduce the big image chunk download output in terminal.

DhavalGojiya force-pushed the feat/es-test-setup branch from 7eacb77 to 49b48ff Compare June 12, 2026 10:42

DhavalGojiya force-pushed the feat/es-test-setup branch from 49b48ff to 82d0134 Compare June 12, 2026 14:16

ulgens reviewed Jun 13, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

ulgens requested changes Jun 13, 2026

View reviewed changes

ulgens reviewed Jun 13, 2026

View reviewed changes

Comment thread pyproject.toml

DhavalGojiya force-pushed the feat/es-test-setup branch from 82d0134 to 3a51a02 Compare June 14, 2026 14:35

DhavalGojiya requested a review from ulgens June 14, 2026 14:35

ulgens reviewed Jun 14, 2026

View reviewed changes

Comment thread .github/workflows/ci.yml Outdated

ulgens reviewed Jun 14, 2026

View reviewed changes

Comment thread setup.py

ulgens reviewed Jun 14, 2026

View reviewed changes

DhavalGojiya added 2 commits June 14, 2026 19:21

feat: add CI test pipeline and Elasticsearch 7 test setup

5131a72

fix(settings): Update middleware variable name and remove deprecated …

9d26a37

…session authentication middleware

DhavalGojiya force-pushed the feat/es-test-setup branch from 3a51a02 to 9d26a37 Compare June 14, 2026 19:24

DhavalGojiya requested a review from ulgens June 14, 2026 19:27

chore(ci): Add --quiet-pull flag to Docker Elasticsearch setup to lim…

7ed6cf8

…it terminal output

ulgens merged commit 81e79b7 into ulgens:main Jul 21, 2026


		BASE_DIR = Path(__file__).parent.resolve()

		SECRET_KEY = "NOBODY expects the Spanish Inquisition!"

Conversation

DhavalGojiya commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary

Tests

Uh oh!

DhavalGojiya commented Jun 12, 2026

Uh oh!

ulgens commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DhavalGojiya Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DhavalGojiya Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ulgens Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ulgens commented Jun 13, 2026

Uh oh!

Uh oh!

DhavalGojiya commented Jun 13, 2026

Uh oh!

ulgens commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ulgens Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ulgens Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DhavalGojiya Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DhavalGojiya commented Jun 14, 2026

Uh oh!

DhavalGojiya commented Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

DhavalGojiya commented Jun 12, 2026 •

edited

Loading

ulgens commented Jun 12, 2026 •

edited

Loading

DhavalGojiya Jun 13, 2026 •

edited

Loading

DhavalGojiya Jun 13, 2026 •

edited

Loading

ulgens Jun 13, 2026 •

edited

Loading

ulgens commented Jun 13, 2026 •

edited

Loading

ulgens Jun 14, 2026 •

edited

Loading

ulgens Jun 14, 2026 •

edited

Loading

DhavalGojiya Jun 14, 2026 •

edited

Loading