Skip to content

suggestions from Cubit pro @GregVernon#713

Open
shimwell wants to merge 1 commit into
developfrom
trelis_script_formatting_improvement
Open

suggestions from Cubit pro @GregVernon#713
shimwell wants to merge 1 commit into
developfrom
trelis_script_formatting_improvement

Conversation

@shimwell

@shimwell shimwell commented Feb 4, 2021

Copy link
Copy Markdown
Collaborator

Proposed changes

Updating the Cubit / Trelis script that makes the DAGMC geometry thanks to suggestions from @GregVernon made over on this issue #711

Thanks very much for helping out Greg

Also noticed a few missing indents for the reflecting surfaces which I'm sure I've fixed before

We can test this locally and get it merged in to develop soon

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@codecov

codecov Bot commented Feb 4, 2021

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.33%. Comparing base (3208686) to head (f860ca6).
⚠️ Report is 759 commits behind head on develop.

Files with missing lines Patch % Lines
...tric_neutronics/make_faceteted_neutronics_model.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #713      +/-   ##
===========================================
- Coverage    98.87%   96.33%   -2.54%     
===========================================
  Files           68       69       +1     
  Lines         4337     4451     +114     
===========================================
  Hits          4288     4288              
- Misses          49      163     +114     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shimwell

shimwell commented Feb 9, 2021

Copy link
Copy Markdown
Collaborator Author

I'm half tempted to hold of on this till we get Cubit in the CI and testing becomes easier. I've still not got around to locally testing this as I've been having VPN / license server issues

@GregVernon

GregVernon commented Feb 9, 2021

Copy link
Copy Markdown

I'm half tempted to hold of on this till we get Cubit in the CI and testing becomes easier. I've still not got around to locally testing this as I've been having VPN / license server issues

I would recommend holding off on this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants