Supports configuring a minimum number of requests for circuit breaker#13459
Merged
Merged
Conversation
kevinpollet
changed the title
kevinpollet
added
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the
RequestThreshold()circuit breaker expression by upgradinggithub.com/vulcand/oxy/v2tov2.2.0.This allows users to combine the existing circuit breaker metrics with a minimum request count condition, for example:
Fixes #10963
Motivation
Traefik's circuit breaker previously could trip based on ratios even when only a small number of requests had been recorded. This change enables users to require a minimum number of requests before the circuit breaker opens, matching the behavior requested in #10963 and the RequestThreshold() support added in vulcand/oxy#256.
More
Additional Notes
The new threshold is exposed through the existing expression option. No new Traefik configuration field is added.