Fix mobile download prompt detection timing - #93
Open
feynon wants to merge 5 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
useEffect, causing the click handlers to be gated until that state was set.Description
isMobilestate fromuseMobileDownloadPromptand changed the hook to callisLikelyMobileDevice()at click time soopenMobileDownloadPromptreliably returnstrueon mobile immediately after load.GlobalMobileDownloadPromptby removing separate mobile-state gating and performingisLikelyMobileDevice()checks inside the document click handler registered in the capture phase so download link clicks are intercepted consistently.components/mobile-download-prompt.tsx.Testing
npm run lint, which failed in this environment because ESLint configuration was not detected (ESLint couldn't find an eslint.config.(js|mjs|cjs) file).npm run build, which failed in this environment due to external Google Fonts TLS/fetch errors during the Next.js build (unrelated to the changed logic) and optional external package warnings from@react-email/render.Codex Task