Skip to content

Refine mobile hamburger/menu to a more minimal footprint #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feynon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refine mobile hamburger/menu to a more minimal footprint #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions components/mobile-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export function MobileMenu({ isOpen, onClose, themeAware = false, hasBanner = fa
const headerCtaLabelClass = downloadButtonLabelMotionClasses
const headerCtaIconClass = `flex h-3 w-3 items-center justify-center text-[0.95em] font-medium leading-none ${downloadButtonIconMotionClasses} sm:h-4 sm:w-4`
const mobileHeaderControlSize = 'h-7 sm:h-8.5'
const mobileMenuButtonSize = 'h-8 w-8 sm:h-9 sm:w-9'
const mobileMenuButtonSize = 'h-7 w-7 sm:h-8 sm:w-8'

// Social icon colors - theme-aware using dark: utilities
const iconBaseColor = themeAware ? 'text-foreground/40 dark:text-muted-foreground' : 'text-black/40'
Expand Down Expand Up @@ -179,47 +179,47 @@ export function MobileMenu({ isOpen, onClose, themeAware = false, hasBanner = fa
aria-label="Close navigation menu"
type="button"
>
<X className={`h-5 w-5 ${themeAware ? 'text-foreground' : 'text-black'}`} aria-hidden />
<X className={`h-4 w-4 ${themeAware ? 'text-foreground' : 'text-black'}`} aria-hidden />
</button>
</div>
</div>

{/* Content area - flex to push social icons to bottom */}
<div className="flex-1 flex flex-col">
{/* Navigation Links - positioned below header */}
<nav className="flex flex-col pt-4">
<nav className="flex flex-col pt-2">
<Link
href="/book"
onClick={onClose}
className={`text-[1.75rem] font-medium tracking-tight ${textColor} py-4 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
className={`text-xl font-medium tracking-tight ${textColor} py-2.5 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
>
Book
</Link>
<Link
href="/roadmap"
onClick={onClose}
className={`text-[1.75rem] font-medium tracking-tight ${textColor} py-4 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
className={`text-xl font-medium tracking-tight ${textColor} py-2.5 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
>
Roadmap
</Link>
<Link
href="/changelog"
onClick={onClose}
className={`text-[1.75rem] font-medium tracking-tight ${textColor} py-4 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
className={`text-xl font-medium tracking-tight ${textColor} py-2.5 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
>
Changelog
</Link>
<Link
href="/blog"
onClick={onClose}
className={`text-[1.75rem] font-medium tracking-tight ${textColor} py-4 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
className={`text-xl font-medium tracking-tight ${textColor} py-2.5 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
>
Blog
</Link>
<Link
href="/sponsor"
onClick={onClose}
className={`text-[1.75rem] font-medium tracking-tight ${textColor} py-4 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
className={`text-xl font-medium tracking-tight ${textColor} py-2.5 pl-[max(1rem,env(safe-area-inset-left,0px))] pr-[max(1rem,env(safe-area-inset-right,0px))] transition-colors ${textColorHover}`}
>
Sponsor
</Link>
Expand Down
14 changes: 7 additions & 7 deletions components/site-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const SiteHeaderChrome = memo(function SiteHeaderChrome({
const headerCtaLabelClass = downloadButtonLabelMotionClasses
const headerCtaIconClass = `flex h-3 w-3 items-center justify-center text-[0.95em] font-medium leading-none ${downloadButtonIconMotionClasses} sm:h-4 sm:w-4 lg:h-5 lg:w-5`
const mobileHeaderControlSize = "h-7 sm:h-8.5"
const mobileMenuButtonSize = "h-8 w-8 sm:h-9 sm:w-9"
const mobileMenuButtonSize = "h-7 w-7 sm:h-8 sm:w-8"
return (
<>
{isBannerVisible && (
Expand Down Expand Up @@ -156,15 +156,15 @@ const SiteHeaderChrome = memo(function SiteHeaderChrome({
</nav>

{/* Right side: Download CTA and mobile menu */}
<div className="flex items-center gap-1 whitespace-nowrap sm:gap-1.5 lg:gap-2 shrink-0">
<div className="flex items-center gap-1 whitespace-nowrap sm:gap-1 lg:gap-2 shrink-0">
<Button
asChild
variant="ghost"
className={`${mobileHeaderControlSize} rounded-sm ${headerCtaPalette} ${downloadButtonMotionClasses} px-2.5 text-xs font-medium sm:px-3.5 sm:text-sm lg:h-9 lg:px-4 lg:text-sm`}
>
<Link
href="/download"
className="group flex items-center gap-1 sm:gap-1.5 lg:gap-2"
className="group flex items-center gap-1 sm:gap-1 lg:gap-2"
onClick={onDownloadClick}
>
<span className={headerCtaLabelClass}>
Expand All @@ -181,10 +181,10 @@ const SiteHeaderChrome = memo(function SiteHeaderChrome({
aria-label="Open navigation menu"
type="button"
>
<span className="flex flex-col items-center justify-center gap-1.5">
<span className={`block h-px w-5 rounded-full ${hamburgerColor} transition-all duration-300`} />
<span className={`block h-px w-5 rounded-full ${hamburgerColor} transition-all duration-300`} />
<span className={`block h-px w-5 rounded-full ${hamburgerColor} transition-all duration-300`} />
<span className="flex flex-col items-center justify-center gap-1">
<span className={`block h-px w-4 rounded-full ${hamburgerColor} transition-all duration-300`} />
<span className={`block h-px w-4 rounded-full ${hamburgerColor} transition-all duration-300`} />
<span className={`block h-px w-4 rounded-full ${hamburgerColor} transition-all duration-300`} />
</span>
</button>
)}
Expand Down