Add opt-in network-ready taint support - #5072
Open
caseydavenport wants to merge 1 commit into
Open
Conversation
Companion to the calico-side change (projectcalico/calico#11985). When Installation.spec.networkReadyTaint is Enabled, the operator: - Installs a MutatingAdmissionPolicy that taints new nodes with node.projectcalico.org/network-not-ready:NoSchedule. The policy ships in the embedded admission set; the core controller filters it out of the desired set unless the toggle is on, so turning the toggle off uninstalls it. - Tolerates the taint on Typha, which is host-networked and must schedule so calico-node can come up and clear the taint. kube-controllers does not tolerate it, since it needs pod networking. - Sets CALICO_MANAGE_NETWORK_READY_TAINT on calico-node and kube-controllers so they manage the taint at runtime. The nodetaint.* policy files are copied in by hand for now; the real sync pulls them from calico/calico-private api/admission once that change merges.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to projectcalico/calico#11985. Adds an opt-in feature that taints nodes until Calico networking is ready, so workloads aren't scheduled onto a node before Calico can service them.
When networkReadyTaint is set to Enabled on the Installation, the operator:
Off by default. The admission-time taint needs Kubernetes 1.32+ for MutatingAdmissionPolicy; on older clusters the policy is skipped and the taint is managed reactively by calico-node and kube-controllers.
Depends on projectcalico/calico#11985 for the calico-node and kube-controllers behavior and the admission policy source. The nodetaint policy files are copied into the embedded set by hand here for now; the real sync pulls them from calico/calico-private once that PR merges.
Related: projectcalico/calico#11331