template module: fix llext build and enable for nvl as well - #11121
Open
ujfalusi wants to merge 2 commits into
Open
template module: fix llext build and enable for nvl as well#11121ujfalusi wants to merge 2 commits into
ujfalusi wants to merge 2 commits into
Conversation
ce50845 ("template: rename template_comp to template") renamed the template_comp to simply template, but left the llext CMakeList.txt and llext.toml.h referencing to wrong names. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Follow mtl/lnl/ptl/wcl and allow the template to be built. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
ujfalusi
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 25, 2026 08:48
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the LLEXT build for the template audio module after the module rename, and enables the template module for NVL rimage configurations as well.
Changes:
- Fix
templateLLEXT build by updating the LLEXT TOML include to the renamedtemplate.toml. - Rename the LLEXT build target from
template_comptotemplateto match the expected target/dependency name. - Enable inclusion of
audio/template/template.tomlin the NVL rimage config whenCONFIG_COMP_TEMPLATEis enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/rimage/config/nvl.toml.h | Enables the template module in NVL rimage config via conditional include. |
| src/audio/template/llext/llext.toml.h | Updates LLEXT config include to ../template.toml (post-rename). |
| src/audio/template/llext/CMakeLists.txt | Renames the LLEXT build target to template to align with build dependencies. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lgirdwood
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename from template_comp left the llext build of the module failing.
Enable it for NVL as well.