-
Notifications
You must be signed in to change notification settings - Fork 94
✨ Add brand logo and page elements settings #2933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
b-l-i-n-d
wants to merge
55
commits into
dev
Choose a base branch
from
feat/logo
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
a820935
feat(icons): add dark mode icon
b-l-i-n-d 7a3fc99
feat(brand-logo): add brand logo template and frontend styles
b-l-i-n-d f0a3ff2
feat(brand-logo): add brand logo settings field
b-l-i-n-d 288c2cc
feat(brand-logo): add brand logo settings field
b-l-i-n-d ec78aa8
feat(page-elements): replace spotlight mode with page element header/…
b-l-i-n-d 39d57cf
feat(icons): replace dashicons with custom footer svg icon in page el…
b-l-i-n-d 6727240
refactor: remove unused CSS selectors from brand logo and page elemen…
b-l-i-n-d e7b2912
refactor: rename brand logo CSS classes from BEM to hyphenated
b-l-i-n-d ceb3978
fix: preserve spotlight mode behavior in page elements default visibi…
b-l-i-n-d b0adfa7
refactor: Add `show_learning_site` header and footer options check
b-l-i-n-d 0a17681
refactor: Revert unintentional changes
b-l-i-n-d 3332625
refactor: Update code readability
b-l-i-n-d a29d553
style: Update header positioning
b-l-i-n-d 798ac8b
Merge branch 'dev' into feat/logo
b-l-i-n-d d64abd6
fix(settings): resolve PHPStan type errors in Options_V2
b-l-i-n-d 11d63b5
refactor(settings): generic image upload list field type
b-l-i-n-d 25965d5
refactor(settings): generic toggle matrix field type
b-l-i-n-d 6e747d1
refactor: Resolve pho stan warning
b-l-i-n-d 164455a
docs: Update since tag
b-l-i-n-d a2b2a5f
refactor: Update since tag and default values
b-l-i-n-d 32d3157
refactor(settings): make image upload list reusable
b-l-i-n-d d960a31
refactor: Remove redundant default value
b-l-i-n-d 44576ba
Merge branch 'dev' into feat/logo
b-l-i-n-d 8842a35
feat: Add sidebar logo visbility controll
b-l-i-n-d 02f4327
Merge branch 'dev' into feat/logo
b-l-i-n-d 172c235
feat(learning-area): track theme site-shell header offset
b-l-i-n-d 0de52dd
style(learning-area): Update footer and sidebar style conflict.
b-l-i-n-d 55318c8
docs: Update since tag
b-l-i-n-d abb1871
refactor: Use ignore-kids to resolve unintentional icon changes
b-l-i-n-d 93d47bc
feat(brand-logo): migrate course builder logo to light brand logo set…
b-l-i-n-d f40341c
feat(settings): reset image_upload_list and toggle_matrix fields
b-l-i-n-d aa5ad9a
style(admin): hide isolated course details wrappers when options disa…
b-l-i-n-d c43ef02
refactor(page-elements): migrate spotlight mode to per-shell visibility
b-l-i-n-d 7c6f665
docs: add project context glossary and learning-area ADR
b-l-i-n-d c3458fc
feat(learning-area): wrap quiz attempt and details in site shell
b-l-i-n-d 2a9c87b
feat(learning-area): track site-header overlay offset for quiz layout
b-l-i-n-d 3346fec
style(learning-area): bound quiz and summary layout to theme shell
b-l-i-n-d c9a6487
refactor(dashboard): move mobile nav into dashboard layout flow
b-l-i-n-d 7244b23
refactor(template): centralize site-shell data resolution
b-l-i-n-d d28fad2
feat(dashboard): apply site-shell offset controller to dashboard layouts
b-l-i-n-d 0d67d6a
style(dashboard): offset dashboard layout beneath theme header in sit…
b-l-i-n-d cb4a620
fix(quiz): bound quiz summary within site shell and reserve header ov…
b-l-i-n-d aebe0a2
fix(logo): use site title as logo alt text
b-l-i-n-d 9605c15
refactor(site-shell): move site-shell controller to frontend services
b-l-i-n-d 42fab85
Merge branch dev into feat/logo
b-l-i-n-d b271225
style: Remove unwanted scss
b-l-i-n-d c3c5baf
feat(image-upload-list): Add description support
b-l-i-n-d 674e8ef
chore: Remove unnecessary code
b-l-i-n-d e4d661e
fix(course): guard attachment image url retrieval for brand logo
b-l-i-n-d de74c63
refactor(template): support header and footer visibility in custom he…
b-l-i-n-d e5ba0ca
fix(options): add fallback normalization for legacy spotlight mode an…
b-l-i-n-d b225934
fix(template): add header role heading selector for theme header dete…
b-l-i-n-d 45392e1
docs(options): update @since version tag for image_upload_list
b-l-i-n-d 4c3794c
fix(options): check both header and footer visibility for legacy spot…
b-l-i-n-d ded4ede
feat(learning-area): move expand button under more pages container an…
b-l-i-n-d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // Theme-aware Tutor branding shared by the dashboard and learning area. | ||
|
|
||
| .tutor-brand-logo-dark { | ||
| display: none; | ||
| } | ||
|
|
||
| [data-tutor-theme='dark'] { | ||
| .tutor-brand-logo-light { | ||
| display: none; | ||
| } | ||
|
|
||
| .tutor-brand-logo-dark { | ||
| display: inline; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ | |
| @forward 'quiz-summary'; | ||
| @forward 'player'; | ||
| @forward 'tour'; | ||
| @forward 'brand-logo'; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.