Fixes #39301 - Add LocationIndicatorActive support for identify LED with IndicatorLED fallback#940
Merged
stejskalleos merged 1 commit intoJul 13, 2026
Conversation
spesnova717
force-pushed
the
feature/location-indicator-active
branch
from
f1d58ea to
8eab381
Compare
…fallback Prefer LocationIndicatorActive for identify status and identify on/off operations when available, and fall back to IndicatorLED for older or partial Redfish implementations. This keeps compatibility across vendors while aligning identify behavior with newer Redfish systems. Add tests for both LocationIndicatorActive and fallback paths. (this commit is intended to be reviewed on top of theforeman#939)
spesnova717
force-pushed
the
feature/location-indicator-active
branch
from
e47b2ee to
8f62b89
Compare
stejskalleos
approved these changes
Jul 13, 2026
stejskalleos
left a comment
stejskalleos
left a comment
Contributor
There was a problem hiding this comment.
🍏 LGTM
I have not tested it personally, but the code change looks good, the scope is clear and to the point, the tests are present, and CI is green, so let's get this in!
Contributor
|
thanks @spesnova717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates Redfish identify LED handling to prefer
LocationIndicatorActivewhen present, while preserving backward compatibility by falling back toIndicatorLEDwhen unavailable.Depends on
This PR builds upon the
IndicatorLEDvalue fix (On→Lit) and thepatch_if_matchusage for identify LED operations introduced in the base PR.Changes
identifystatusLocationIndicatorActivefirst (true => on,false => off).IndicatorLEDwhenLocationIndicatorActiveis absent.identifyon/identifyoffpatch_identify.patch_identifyselects either aLocationIndicatorActiveorIndicatorLEDpayload based on availability, then applies it viapatch_if_match.Compatibility
Backward compatible: systems without
LocationIndicatorActivecontinue to work viaIndicatorLED.