[release-v0.37.x] fix: resolve golangci-lint errors (cherry-pick from main)#3024
Open
divyansh42 wants to merge 1 commit into
Open
[release-v0.37.x] fix: resolve golangci-lint errors (cherry-pick from main)#3024divyansh42 wants to merge 1 commit into
divyansh42 wants to merge 1 commit into
Conversation
tekton-robot
added
the
do-not-merge/release-note-label-needed
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/S
divyansh42
force-pushed
the
fix/lint-errors-release-v0.37.x
branch
from
b07dda3 to
70c1fd2
Compare
- cmd/tkn/main.go: suppress G702 (command injection) with nosec annotation, exCmd comes from plugin discovery path - pkg/formatted/color.go: suppress G115 (integer overflow int->uint32) with nolint annotation, threshold is bounded by palette length - pkg/plugins/plugins.go: suppress G703 (path traversal) with nosec annotation, fpath is from filepath.Join with validated path - pkg/suggestion/suggest.go: rename local variable 'min' to 'minCost' to avoid shadowing the built-in min function Signed-off-by: Divyanshu Agrawal <diagrawa@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
divyansh42
force-pushed
the
fix/lint-errors-release-v0.37.x
branch
from
70c1fd2 to
0607b89
Compare
Member
Author
|
/retest |
Member
Author
|
/release-note-none |
tekton-robot
added
release-note-none
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maintorelease-v0.37.xto unblock CI for all open PRs on this branch#nosecannotationnolintannotation#nosecannotationmintominCostto avoid shadowing the built-inminfunction (revive: redefines-builtin-id)Test plan
/release-note-none
Made with Cursor