Merge #49 - #50
Merged
Merged
Conversation
* Add MToon rendering support * Fix MToon shader build on unsupported SDKs * Fix visionOS RealityKit tests * Separate unrelated example changes * Address MToon review feedback * Improve MToon shading fidelity * Use bundled RealityKit MToon shaders * Ensure VRMRealityKit bundle resources exist * Adjust RealityKit MToon tests for shader fallback * Clarify RealityKit MToon fallback tests * Precompile MToon metallibs and make MToon optional Ship per-platform precompiled MToon Metal libraries as package resources so CustomMaterial works regardless of the consumer's build system (swift build does not compile package .metal sources, and newer Xcodes require a separately installed Metal Toolchain). Add an isMToonEnabled option (default true) to both loaders, make shader-load test failures hard failures, unify the example model rotation offsets, and drop unrelated whitespace changes. Co-authored-by: Cursor <cursoragent@cursor.com> * Add AR-safe MToon rendering mode for RealityKit. Introduce VRMRenderingMode (.nonAR default, .ar) to omit geometry modifiers and outline entities that crash in AR shadow-caster passes, while keeping CustomMaterial MToon shading. Document AR usage in README and add integration tests. Co-authored-by: Cursor <cursoragent@cursor.com> * Disable shadow casting for AR MToon CustomMaterial rendering. Apply DynamicLightShadowComponent and GroundingShadowComponent on AR entity trees, force opaque blending for surface-only MToon, and expand AR integration tests. Co-authored-by: Cursor <cursoragent@cursor.com> * Fix AR rendering mode build on visionOS * Fix AR MToon alpha blending * Fix AR MToon texture transforms * Fix visionOS tests and MToon shade fallback * Limit MToon rendering support to RealityKit * Address RealityKit MToon review feedback * Fix MToon review issues and add example toggles * Stabilize MToon texture semantic tests --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.