Skip to content

feat(run-task): Add perfherder profile markers for Git VCS operations#1005

Merged
ahal merged 1 commit into
taskcluster:mainfrom
ahal:ahal/oqrmsyszxpts
Jul 15, 2026
Merged

feat(run-task): Add perfherder profile markers for Git VCS operations#1005
ahal merged 1 commit into
taskcluster:mainfrom
ahal:ahal/oqrmsyszxpts

Conversation

@ahal

@ahal ahal commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

While implementing this patch, I learned that Perfherder actually does
not process PERFHERDER_DATA anymore. However the TaskclusterETL is
still processing it (independently of Perfherder). So that's how we're
still able to get clone metrics out of robustcheckout.

Given that TaskclusterETL is slated to be removed, it's not great to be
adding a new feature that depends on it. However this will allow us to
get detailed clone metrics for Git in the short term, which will help
out with the migration.

Longer term, we'll need to figure out an alternative way to profile
run-task that doesn't rely on TaskclusterETL.

@ahal ahal self-assigned this Jul 10, 2026
@ahal ahal force-pushed the ahal/oqrmsyszxpts branch 3 times, most recently from f6a28a7 to 3813172 Compare July 10, 2026 18:41
While implementing this patch, I learned that Perfherder actually does
not process `PERFHERDER_DATA` anymore. However the TaskclusterETL is
still processing it (independently of Perfherder). So that's how we're
still able to get clone metrics out of robustcheckout.

Given that TaskclusterETL is slated to be removed, it's not great to be
adding a new feature that depends on it. However this will allow us to
get detailed clone metrics for Git in the short term, which will help
out with the migration.

Longer term, we'll need to figure out an alternative way to profile
`run-task` that doesn't rely on TaskclusterETL.
@ahal ahal force-pushed the ahal/oqrmsyszxpts branch from 3813172 to 5a6b395 Compare July 14, 2026 16:08
@ahal ahal marked this pull request as ready for review July 14, 2026 16:09
@ahal ahal requested a review from a team as a code owner July 14, 2026 16:09
@ahal ahal requested a review from hneiva July 14, 2026 16:09

@jcristau jcristau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How easy will it be to distinguish hg vs git once we get this in bigquery? Might be useful to have some marker...

@ahal

ahal commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

How easy will it be to distinguish hg vs git once we get this in bigquery? Might be useful to have some marker...

There's a serverUrl field that is set for Hg but not set for Git.. It's not ideal, but the underlying BigQuery table that TaskclusterETL pushes to has a well defined schema. So unless we want to:

A) Update the schema in BQ
B) Update TaskclusterETL to forward our new marker (I really don't want to do this)

We can't make any changes to the existing format :/

@ahal ahal merged commit 810d2d1 into taskcluster:main Jul 15, 2026
23 of 24 checks passed
@ahal ahal deleted the ahal/oqrmsyszxpts branch July 15, 2026 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants