feat(shield): add host.profiles for per-node-type resource sizing - #2682
Open
aaronm-sysdig wants to merge 1 commit into
Open
feat(shield): add host.profiles for per-node-type resource sizing#2682aaronm-sysdig wants to merge 1 commit into
aaronm-sysdig wants to merge 1 commit into
Conversation
Adds an optional host.profiles list that renders one host shield DaemonSet per node type from a single Helm release. Each profile deep-merges its resource, node_selector, affinity and toleration overrides over the base host settings. Empty profiles (the default) preserves the existing single-DaemonSet behaviour and name unchanged. Everything else (RBAC, ConfigMap, Secrets, cluster Deployment) stays singular - only the host DaemonSet multiplies. - host.profiles[] in values.yaml with documented example - JSON schema validation (name + node_selector required per profile) - host.daemonset.name helper for profile-suffixed, 63-char-truncated names - sysdig/host-profile label on per-profile DaemonSets - install-time NOTES.txt warning that node_selectors must be disjoint - helm-unittest: backward-compat + multi-profile merge assertions - docs/host-profiles.md usage guide
Contributor
|
Hi @aaronm-sysdig. Thanks for your PR. After inspecting your changes someone with write access to this repo needs |
aaronm-sysdig
marked this pull request as ready for review
July 10, 2026 10:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Adds an optional
host.profileslist to the shield chart so a single Helm release can deploy one right-sized host shield DaemonSet per node type, instead of forcing one resource config across a mixed-node cluster.On clusters with heavy and light nodes, a single
host.resourcesblock means you either size for the heaviest node (wasting resources on the light ones) or size for the lightest (risking OOMKilled/throttling on the heavy ones).host.profileslets each node type get its own DaemonSet with its own resources, pinned bynodeSelector.How it works
Each profile deep-merges its overrides (
resources,node_selector,affinity,tolerations) over the basehost.*settings, and renders one DaemonSet. The Kubernetes scheduler handles placement at runtime vianodeSelector- Helm doesn't need to know anything about the nodes.Everything else (RBAC, ConfigMap, Secrets, cluster Deployment) stays singular - only the host DaemonSet multiplies.
Already in production
A customer is already running this from a fork across mixed node types, targeting Karpenter/instance-type labels, including an "else
default" catchall profile (emptynode_selector+NotInnode affinity) to guarantee coverage of un-profiled nodes. It targets nodes as expected.Backward compatibility
host.profilesdefaults to[]. When empty, the chart renders exactly as before - a single host DaemonSet with the same name and no extra labels. Existing installs are unaffected until profiles are explicitly set.Scope / notes
daemonset-windows.yamlis intentionally untouched.Chart.yamlversion bump orREADME.mdregen - left out deliberately so this can be folded into your next release cut without version/README conflicts.values.yamlcarries the documented value somake docswill pick it up when you regenerate.sysdig/host-profile: <name>label (selector + pod), matching the chart's existingsysdig/*label convention.Testing
helm unittest --strictgreen: backward-compat (empty → 1 DaemonSet, default name, no profile label) + multi-profile merge (per-profile resources, node selectors, inherited base values).helm lintclean.Checklist
values.yaml(README regen left to release cut)tests/with_testsuffix