Skip to content

Base: Enhance Bitmask with constexpr support and exhaustive tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dragonfruit-blue wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Base: Enhance Bitmask with constexpr support and exhaustive tests #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions src/Base/Bitmask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,18 +159,45 @@ class Flags {
constexpr Flags<Enum> operator&(const Enum &f) const {
return i & f;
}
constexpr Flags<Enum> &operator^=(const Flags<Enum> &other) {
i ^= other.i;
return *this;
}
constexpr Flags<Enum> &operator^=(const Enum &f) {
i ^= f;
return *this;
}
constexpr Flags<Enum> operator^(const Flags<Enum> &other) const {
return i ^ other.i;
}
constexpr Flags<Enum> operator^(const Enum &f) const {
return i ^ f;
}
constexpr bool operator==(const Flags<Enum> &other) const {
return isEqual(other);
}
constexpr bool operator!=(const Flags<Enum> &other) const {
return !isEqual(other);
}
constexpr bool operator==(const Enum &f) const {
return i == f;
}
constexpr bool operator!=(const Enum &f) const {
return i != f;
}

@anomolous-lemur anomolous-lemur Apr 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary -- we target C++23, which will autogenerate operator!=.

constexpr Flags<Enum> operator~() const {
return ~i;
}

constexpr bool operator!() const {
return !i;
using u = typename std::underlying_type<Enum>::type;
return !static_cast<u>(i);
}

explicit operator bool() const {
constexpr explicit operator bool() const {
return toUnderlyingType() != 0;
}
typename std::underlying_type<Enum>::type toUnderlyingType() const {
constexpr typename std::underlying_type<Enum>::type toUnderlyingType() const {
return static_cast<typename std::underlying_type<Enum>::type>(i);
}
};
Expand Down
Loading