Fix remaining ResolverFully recursion edge case - #2375
Open
bartolomeooo wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue described in #2374.
It addresses a remaining
ResolverFullyrecursion edge case for an OpenAPI 3.1 self-referencing schema combined withallOfwhen parsing withresolve = trueandresolveFully = true.In this scenario,
ResolverFullymay re-attach a schema that is still present inschemasInProgressback into a newly aggregated schema, which can create a cyclic Java object graph.This PR updates the recursive property re-attachment logic to treat in-progress schemas as recursive placeholders in this path, and adds a regression test covering the
OAS 3.1 + allOf + self-referencecase.Fixes: #2374
Type of Change
Checklist
Screenshots / Additional Context
Regression test added for a minimal OpenAPI 3.1 reproducer with:
allOfresolveFully = trueThe new fixture uses this minimal shape: