refactor: migrate WIDENAMES to wideLabel capability - #8010
Open
severe77 wants to merge 3 commits into
Open
Conversation
severe77
requested review from
Ashutoshx7,
omsuneri and
walterbender
as code owners
August 10, 2026 08:03
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8010 +/- ##
==========================================
+ Coverage 62.19% 62.23% +0.03%
==========================================
Files 187 187
Lines 58324 58331 +7
==========================================
+ Hits 36273 36300 +27
+ Misses 22051 22031 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@Chaitu7032 look OK to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the remaining hardcoded
WIDENAMESblock classification with the existing capability-based approach.The affected blocks now declare the
wideLabelcapability, and consumers useBlock.hasWideLabel()instead of maintaining a separate list of block names.What changed
wideLabelcapability to the blocks previously listed inWIDENAMES.Block.hasWideLabel()helper.WIDENAMESconsumers with capability checks.WIDENAMESand emptyEXTRAWIDENAMESlists.Behavior
This is a refactoring only. The existing wide-label behavior is preserved while removing the hardcoded block-name classification.
Testing
PR Category