fix: event listener leak in helper.js - #7975
Open
Jetshree wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7975 +/- ##
==========================================
+ Coverage 62.05% 62.06% +0.01%
==========================================
Files 187 187
Lines 58377 58394 +17
==========================================
+ Hits 36227 36244 +17
Misses 22150 22150 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes an event listener leak in planet/js/helper.js.
Each time hideOnClickOutside() was called for the same anchor element it added a new document click listener without removing the previous one, due to this duplicate listeners stacked unnecessarily.
I added a module scoped WeakMap to track the active listener for each anchor element.
Before adding a new listener, the existing one is removed which ensure only one outside click listener exists per anchor at a time.
PR Category
Testing Performed
Before: repeatedly opening and closing the share boxes kept adding new document click listeners

After: listener count consistently stayed at the baseline

Additional Notes for Reviewers