Fix EqualExportedValues on recursive values#1916
Open
cyphercodes wants to merge 1 commit into
Open
Conversation
| if !EqualExportedValues(t, expected, actual) { | ||
| t.Error("expected EqualExportedValues to handle recursive values") | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can we add tests to cover reflect.Map and reflect.Array/Slice? I think they are the hairiest parts of this PR and currently uncovered.
I wonder if it's possible to move the result, ok := visited[visit]; ok check earlier in the function to avoid spreading it out to 3 different places. Maybe it's not possible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
EqualExportedValuesso copying exported fields terminates for recursive values.Changes
Motivation
copyExportedFieldsrecursed indefinitely on pointer cycles, causingEqualExportedValuesto time out or overflow the stack for recursive data structures.Exact test commands run:
go test ./assert -run TestEqualExportedValuesRecursiveStruct -count=1 -timeout=3s(failed before the fix; timed out reproducing the bug)go test ./assert -run 'TestEqualExportedValuesRecursiveStruct|TestEqualExportedValues|TestObjectsExportedFieldsAreEqual|TestCopyExportedFields' -count=1go test ./assert -count=1go test ./... -count=1git diff --checkRelated issues
Fixes #1915