fix: 🐛 improve LruTtlMap - #106
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves LruTtlMap’s TTL semantics and internal bookkeeping so that expiry metadata stays consistent with the underlying LRU map, and so callers get sensible default “current time” behavior.
Changes:
- Add clearer API documentation for
LruTtlMap, including explicit semantics fornowand absolute expiry deadlines. - Change
LruTtlMap.has()to defaultnowtoDate.now()so expired entries are treated as missing even when callers omitnow. - Fix LRU-eviction cleanup by having
LruMap.set()evict viathis.delete(...), allowing subclasses (likeLruTtlMap) to keep side-maps in sync, and add tests covering expiry side-map non-leak scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/LruTtlMap.ts | Documents TTL behavior and updates default now handling; ensures expiry bookkeeping remains aligned with reads/writes. |
| src/LruMap.ts | Ensures evictions go through polymorphic delete() so subclasses can perform cleanup (e.g., removing expiry metadata). |
| src/tests/LruTtlMap.spec.ts | Adds regression tests to ensure expiry side-map does not leak on eviction/overwrite/clear/delete and validates default-now expiry behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 2.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.