Skip to content

apply RUSTC_WRAPPER when querying rustc version - #737

Merged
stepancheg merged 1 commit into
stepancheg:masterfrom
RalfJung:rustc-wrapper
Oct 15, 2024
Merged

apply RUSTC_WRAPPER when querying rustc version#737
stepancheg merged 1 commit into
stepancheg:masterfrom
RalfJung:rustc-wrapper

Conversation

@RalfJung

@RalfJung RalfJung commented Sep 1, 2024

Copy link
Copy Markdown
Contributor

Fixes #735

The alternative would have been to depend on https://crates.io/crates/rustc_version, but that would have been a larger change.

@RalfJung

RalfJung commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

@stepancheg did you have any chance to look at this? :)
This crate shows up in the rustc compiler workspace, which makes this a blocking issue for rust-lang/rust#127682.

@stepancheg

Copy link
Copy Markdown
Owner

I don't fully understand it, but someone else asked me to merge it, so this is it.

@stepancheg

Copy link
Copy Markdown
Owner

Actually, I removed nightly detection from build.rs of protobuf crate, because it is not needed for the crate itself, only for benches, and I moved benches outside.

@RalfJung

Copy link
Copy Markdown
Contributor Author

That's even better, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build script does not honor RUSTC_WRAPPER

2 participants